Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB.grpc does not exist #125

Closed
angelcervera opened this issue Jun 10, 2016 · 5 comments
Closed

PB.grpc does not exist #125

angelcervera opened this issue Jun 10, 2016 · 5 comments

Comments

@angelcervera
Copy link

In the documentation for version 0.4.20 (http://trueaccord.github.io/ScalaPB/sbt-settings.html) said

GRPC
Generating GRPC stubs for services is enabled by default. To disable:
PB.grpc := false

But PB.grpc is not a member of ScalaPbPlugin.

@thesamet
Copy link
Contributor

Thanks for reporting, I updated the page. The short version is that this is 0.5.x setting. if you are on 0.4.x then services will not be generated anyway.

@angelcervera
Copy link
Author

angelcervera commented Jun 10, 2016

Hi @thesamet
Is 0.5 ready for production?
I am starting to develop a library, so I don't care for a short time production availability.
If it will be ready in few months or if it is not going to change a lot in the generated code, for me it is ok.
Are you focus in 0.5 or 0.6?

What do you think? branch 0.5 or 0.4?

@eiennohito
Copy link
Contributor

@angelcervera Why do you need to depend on implementation details?

Interface should not change much I hope.

@angelcervera
Copy link
Author

@eiennohito Sorry because the confusion. I was asking about changes in the interface. I don't want to start to use a version whose interface is not mature enough.

@thesamet
Copy link
Contributor

thesamet commented Jun 10, 2016

0.5.x is in active development, yet I am not anticipating breaking changes to the generated code. We're generally adding features in a backwards compatible way.

"production ready" means different things to different people :), We are happily using 0.5.x in production at TrueAccord, though 0.5.x relies on protobuf 3.0.0-beta-something. We're essentially waiting on protobuf 3.0 final to come out so we can cut a "stable" ScalaPB.

I'd recommend not building anything new on top of 0.4.x since we know the generated code is not compatible with 0.5.x (though the changes are pretty small)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants