Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc should not depend on grpc-all #113

Closed
eiennohito opened this issue May 8, 2016 · 2 comments · Fixed by #114
Closed

grpc should not depend on grpc-all #113

eiennohito opened this issue May 8, 2016 · 2 comments · Fixed by #114

Comments

@eiennohito
Copy link
Contributor

eiennohito commented May 8, 2016 •
edited
Loading

  1. It will be removed: Stop using grpc-all grpc/grpc-java#1597
  2. It repackages classes for everything making navigation to sources in IDE a pain.

Proposal for fix: runtime should depend on grpc-stub, tests should depend on grpc-netty.
@eiennohito
Copy link
Contributor Author

eiennohito commented May 8, 2016 •
edited
Loading

  1. Edit: My bad, it will not be removed, but will become a simple aggregation project.

However, I believe that dependency on all is still not needed.
Service generation depends only on grpc-stub and should not expose more dependencies.

@thesamet
Copy link
Contributor

thesamet commented May 8, 2016

Fine by me, PR will be welcome.

@eiennohito eiennohito mentioned this issue May 8, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

depend not on grpc-all, but on more fine-grained dependencies eiennohito/ScalaPB
2 participants
@thesamet @eiennohito