From 481621a5ce631b2e2adff893955e5609adc4adc6 Mon Sep 17 00:00:00 2001 From: Albert Meltzer <7529386+kitbellew@users.noreply.github.com> Date: Wed, 3 Apr 2024 21:27:52 -0700 Subject: [PATCH] Router: refactor nlPolicy for binpack.callSite --- .../main/scala/org/scalafmt/internal/Router.scala | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/scalafmt-core/shared/src/main/scala/org/scalafmt/internal/Router.scala b/scalafmt-core/shared/src/main/scala/org/scalafmt/internal/Router.scala index 189214f92e..383322b86f 100644 --- a/scalafmt-core/shared/src/main/scala/org/scalafmt/internal/Router.scala +++ b/scalafmt-core/shared/src/main/scala/org/scalafmt/internal/Router.scala @@ -1288,20 +1288,19 @@ class Router(formatOps: FormatOps) { val nlPolicy = { def newlineBeforeClose = decideNewlinesOnlyBeforeClose(close) - def binPackOnelinePolicy = - if (needOnelinePolicy) nextCommaOnelinePolicy - .getOrElse(decideNewlinesOnlyBeforeCloseOnBreak(close)) - else NoPolicy + def binPackOnelinePolicyOpt = + if (needOnelinePolicy) nextCommaOnelinePolicy else Some(NoPolicy) + def bothPolicies = newlineBeforeClose & binPackOnelinePolicyOpt if (onlyConfigStyle) - if (styleMap.forcedBinPack(leftOwner)) newlineBeforeClose & - binPackOnelinePolicy + if (styleMap.forcedBinPack(leftOwner)) bothPolicies else splitOneArgOneLine(close, leftOwner) | newlineBeforeClose else if ( mustDangleForTrailingCommas || style.danglingParentheses.tupleOrCallSite(isTuple(leftOwner)) && (style.newlines.sourceIgnored || !style.optIn.configStyleArguments) - ) newlineBeforeClose & binPackOnelinePolicy - else binPackOnelinePolicy + ) bothPolicies + else binPackOnelinePolicyOpt + .getOrElse(decideNewlinesOnlyBeforeCloseOnBreak(close)) } val nlMod = if (rightIsComment && nlOnly) getMod(ft)