forked from eslint-community/eslint-plugin-promise
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathprefer-await-to-callbacks.js
92 lines (88 loc) · 2.59 KB
/
prefer-await-to-callbacks.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
'use strict'
const rule = require('../rules/prefer-await-to-callbacks')
const { RuleTester } = require('./rule-tester')
const ruleTester = new RuleTester({
parserOptions: {
ecmaVersion: 8,
},
})
const message = 'Avoid callbacks. Prefer Async/Await.'
ruleTester.run('prefer-await-to-callbacks', rule, {
valid: [
'async function hi() { await thing().catch(err => console.log(err)) }',
'async function hi() { await thing().then() }',
'async function hi() { await thing().catch() }',
'dbConn.on("error", err => { console.error(err) })',
'dbConn.once("error", err => { console.error(err) })',
'heart(something => {})',
'getErrors().map(error => responseTo(error))',
'errors.filter(err => err.status === 402)',
'errors.some(err => err.message.includes("Yo"))',
'errors.every(err => err.status === 402)',
'errors.filter(err => console.log(err))',
'const error = errors.find(err => err.stack.includes("file.js"))',
'this.myErrors.forEach(function(error) { log(error); })',
'find(errors, function(err) { return err.type === "CoolError" })',
'map(errors, function(error) { return err.type === "CoolError" })',
'_.find(errors, function(error) { return err.type === "CoolError" })',
'_.map(errors, function(err) { return err.type === "CoolError" })',
],
invalid: [
{
code: 'heart(function(err) {})',
errors: [{ message }],
},
{
code: 'heart(err => {})',
errors: [{ message }],
},
{
code: 'heart("ball", function(err) {})',
errors: [{ message }],
},
{
code: 'function getData(id, callback) {}',
errors: [{ message }],
},
{
code: 'const getData = (cb) => {}',
errors: [{ message }],
},
{
code: 'var x = function (x, cb) {}',
errors: [{ message }],
},
{
code: 'cb()',
errors: [{ message }],
},
{
code: 'callback()',
errors: [{ message }],
},
{
code: 'heart(error => {})',
errors: [{ message }],
},
{
code: `async.map(files, fs.stat, function(err, results) { if (err) throw err; });`,
errors: [{ message }],
},
{
code: `_.map(files, fs.stat, function(err, results) { if (err) throw err; });`,
errors: [{ message }],
},
{
code: `map(files, fs.stat, function(err, results) { if (err) throw err; });`,
errors: [{ message }],
},
{
code: `map(function(err, results) { if (err) throw err; });`,
errors: [{ message }],
},
{
code: `customMap(errors, (err) => err.message)`,
errors: [{ message }],
},
],
})