CodeAction is not forwarded

[eed3si9n]

Originally posted by @lrytz in #1214 (reply in thread)

I managed to track it down it down:

• the first build/publishDiagnostics is sent when the problem is reported through the DelegatingReporter
• the second one is sent when compilation is finished, in sbt's sendSuccessReport. Here the Problems are taken from the CompileAnalysis. This data structure is also populated through the compiler interface, but here the actions are discarded.

@eed3si9n it seems we need to add the actions parameter to xsbti.AnalysisCallback.problem. Can we do that with a new overload in a binary compatbile manner?

[eed3si9n]

So I guess @adpi2 introduced resending mechanism via Analysis in sbt/sbt#5956 because compilation that got skipped over by Zinc may still contain useful compiler warnings that we need to retain or resend? I wonder if we should reevaluate if that's still needed since we used to send all of the diagnoses back then, but now we only send the changes?

[eed3si9n]

Re: AnalysisCallback, I guess we can't just add a method because it's on the receiving end of a method call.

	Scala 3.3.0	Scala 3.3.next	Scala 2.13.11	Scala 2.13.next
Zinc 1.9.2	✅	do not send actions	✅	do not send actions
Zinc 1.9.next	⚠️	send action, maybe	✅	send actions, maybe

If we added an overload, then 3.3.0 won't use it because it's already released a binary compiler bridge, Scala 2.x can use it because the source-distributed compiler bridge can immediately use the method; however, Scala 3.3.next and 2.13.next also cannot use it because it needs to be compatible with current Zinc 1.9.2.

This means that we need a mechanism to check if the current Zinc supports new CodeAction and only then send them.