description in upstart config should be taken from packageDescription not from packageSummary

[kretes]

having

com.typesafe.sbt.packager.debian.Keys.packageDescription in SbtNativePackager.Linux := "descr",
com.typesafe.sbt.packager.debian.Keys.packageSummary in SbtNativePackager.Linux := "sum",

when I run debian:packageBin I get in /etc/init/package.conf

which contains:

description "sum"

which is bad, as I expected it to be 'descr'

The problem is more important than it seems, as packageSummary is not required, but when it is unspecified - file /etc/init/my-package.conf is invalid, and the service is not registered.

init-checkconf /etc/init/my-package.conf 
ERROR: File /etc/init/my-package.conf: syntax invalid:
init:my-package.conf:3: Expected token

[muuki88]

I think the main point is that a summary should be a one-liner and the description can be multline.
This was the main reason to use the packageSummary for the description field in upstart. What would you suggest?

[kretes]

Ok, we should at least require that, as it is required to provide description. when I do not have it - I get

 Stack trace suppressed: run last debian:debianControlFile for the full output.
[error] (debian:debianControlFile) packageDescription in Debian cannot be empty. Use
[error]                  packageDescription in Debian := "My package Description"

so - let's maybe add same rule here?

[kretes]

BTW - why are there multiple 'keys classes', e.g

com.typesafe.sbt.packager.debian.Keys
com.typesafe.sbt.packager.linux.Keys

? shouldn't it be that keys are not duplicated , but we control the value by specifying sbt scope?

[muuki88]

This check is done by dpkg-build. So what we need would be a warning if you are using
a server loader that requires a packageSummary. That's actually a bigger tasks as we don't have any validation task at the moment.

The keys are the same. There is a common trait which gets extended. Just use

import NativePackagerKeys._