Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kaml #1540

Closed
Tracked by #1561
nulls opened this issue Oct 31, 2022 · 3 comments · Fixed by #1654
Closed
Tracked by #1561

Upgrade kaml #1540

nulls opened this issue Oct 31, 2022 · 3 comments · Fixed by #1654
Assignees
Milestone

Comments

@nulls
Copy link
Member

nulls commented Oct 31, 2022

kaml uses kotlinx.serialization and it leads to dependency issue in ktlint running is due to sarif4k.

So, the main problem is in ktlint:

     |    \--- io.github.detekt.sarif4k:sarif4k:0.0.1
     |         +--- org.jetbrains.kotlinx:kotlinx-serialization-json:1.1.0
     |         |    \--- org.jetbrains.kotlinx:kotlinx-serialization-json-jvm:1.1.0
     |         |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.30 -> 1.7.20 (*)
     |         |         +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.4.30 -> 1.7.20
     |         |         \--- org.jetbrains.kotlinx:kotlinx-serialization-core:1.1.0
     |         |              \--- org.jetbrains.kotlinx:kotlinx-serialization-core-jvm:1.1.0
     |         |                   +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.30 -> 1.7.20 (*)
     |         |                   \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.4.30 -> 1.7.20

It uses https://github.com/detekt/sarif4k which uses the old kotlinx serialization.
There is a PR to upgrade it: detekt/sarif4k#4

After it, need to upgrade it in ktlint

Originally posted by @nulls in #1518 (comment)

@nulls nulls self-assigned this Oct 31, 2022
@nulls nulls mentioned this issue Nov 15, 2022
8 tasks
@nulls nulls added this to the ktlint-wrapper milestone Nov 22, 2022
@sanyavertolet
Copy link
Member

sanyavertolet commented Mar 14, 2023

@nulls Is this issue still relevant? Seems like kotlinx.serialization was updated in detekt/safif4k a long time ago

@nulls
Copy link
Member Author

nulls commented Mar 14, 2023

@nulls Is this issue still relevant? Seems like kotlinx.serialization was updated in detekt/safif4k a long time ago

I don't know -- need to check dependencies

@nulls
Copy link
Member Author

nulls commented Apr 5, 2023

closed by shading kotlinx.serialization in #1654

@nulls nulls closed this as completed Apr 5, 2023
@nulls nulls linked a pull request Apr 5, 2023 that will close this issue
@nulls nulls modified the milestones: ktlint-wrapper, 2.0.0 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants