Skip to content
This repository has been archived by the owner on Nov 27, 2022. It is now read-only.

fix: clearTimout on unmount (#1103) #1201

Merged
merged 1 commit into from
Jul 29, 2021
Merged

fix: clearTimout on unmount (#1103) #1201

merged 1 commit into from
Jul 29, 2021

Conversation

dimaportenko
Copy link
Contributor

@dimaportenko dimaportenko commented Jul 8, 2021 •
edited by satya164
Loading

This PR fixes #1103.
Basically, just clear timeout on component unmount.

BennEntterprise
BennEntterprise reviewed Jul 22, 2021
View reviewed changes
Copy link

@BennEntterprise BennEntterprise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me. A fairly straightforward unmounting of a listener.

@dimaportenko
Copy link
Contributor Author

At least 1 approving review is required by reviewers with write access.

@BennEntterprise can you approve it?

@BennEntterprise
Copy link

@dimaportenko I do no have write access.

I found this issue in my own work but would have agreed that this is the proper way to solve it.

@satya164
Copy link
Owner

/rebase

satya164
satya164 approved these changes Jul 29, 2021
View reviewed changes
Copy link
Owner

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@satya164 satya164 merged commit 4b30aed into satya164:main Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BennEntterprise BennEntterprise BennEntterprise left review comments

@satya164 satya164 satya164 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SceneView - Warning: Can't perform a React state update on an unmounted component.
3 participants
@dimaportenko @BennEntterprise @satya164