Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Rule: Force pseudo element/class nesting #268

Closed
DanPurdy opened this issue Oct 8, 2015 · 5 comments · Fixed by #272
Closed

New Rule: Force pseudo element/class nesting #268

DanPurdy opened this issue Oct 8, 2015 · 5 comments · Fixed by #272
Assignees
@DanPurdy
Labels
in progress rule
Milestone
1.3.0

Comments

@DanPurdy
Copy link
Member

DanPurdy commented Oct 8, 2015

As discussed in #256

Rule should enforce the nesting of pseudo elements/classes
@DanPurdy DanPurdy self-assigned this Oct 8, 2015
@DanPurdy DanPurdy added this to the 1.3.0 milestone Oct 8, 2015
@DanPurdy DanPurdy mentioned this issue Oct 9, 2015
Merged
@DanPurdy DanPurdy modified the milestones: 1.3.0, 1.4.0 Oct 9, 2015
@bgriffith bgriffith modified the milestones: 1.3.0, 1.4.0 Oct 10, 2015
@esr360
Copy link

esr360 commented Nov 1, 2016

A value of 0 is not allowed. zero must be used

This seems wrong to me? Setting this to zero should surely allow 0 instead of none? As far as I'm aware border: zero is not valid.

@DanPurdy
Copy link
Member Author

DanPurdy commented Nov 1, 2016 •
edited
Loading

@esr360 sorry, what are you referring to and where? The border 0 rule? Can you open a new issue if there's something you've found that's wrong as this issue is over a year old, closed and seems to not have anything to do with what you're mentioning otherwise it'll just get lost. Thanks

@esr360
Copy link

esr360 commented Nov 1, 2016

Sorry @DanPurdy I posted this on the wrong issue, I had another relevant issue open relating to this, I meant to post this here: #861

I will open a new issue though.

@DanPurdy
Copy link
Member Author

DanPurdy commented Nov 1, 2016

It's ok no problem, just got a little confused! 👍

@DanPurdy DanPurdy mentioned this issue Nov 2, 2016
Merged
@DanPurdy
Copy link
Member Author

DanPurdy commented Nov 2, 2016

Hey @esr360 I've put a PR in to address your issue, feel free to add any comments there if you feel necessary. see #926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanPurdy DanPurdy

Labels
in progress rule
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Rule: Force pseudo nesting DanPurdy/sass-lint
3 participants
@DanPurdy @bgriffith @esr360