Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Defaults For Plot Requests are Non-Standard for PROCs #516

Closed
dmsenter89 opened this issue Jan 20, 2023 · 1 comment · Fixed by #517
Closed

Some Defaults For Plot Requests are Non-Standard for PROCs #516

dmsenter89 opened this issue Jan 20, 2023 · 1 comment · Fixed by #517

Comments

@dmsenter89
Copy link
Contributor

The function SASProcCommons._makeProcCallMacro sets some defaults for PROC calls that are non-standard. Specifically, it sets the procopts plot=all by default for STAT and ETS PROCs (with an exception introduced in #514). This is non-standard; the correct procopts is plots=all (with plural s). See for example PROC TIMESERIES, PROC UCM, PROC REG, and PROC TTEST. Some, but not all, PROCs may translate plot=all to plots=all behind the scenes, but is safer to use the language default.

I propose changing the two defaults to plots=all. I'm happy to make a PR fixing this.

@tomweber-sas
Copy link
Contributor

Sounds great! Thanks again for contributing fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants