Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsass 0.13.2 use deprecated -std=gnu++0x #2459

Closed
plavcik opened this issue Aug 5, 2017 · 6 comments
Closed

libsass 0.13.2 use deprecated -std=gnu++0x #2459

plavcik opened this issue Aug 5, 2017 · 6 comments
Labels

Comments

@plavcik
Copy link

plavcik commented Aug 5, 2017

I propose switch to

-std=c++11

--- /tmp/setup.py       Sat Aug  5 11:19:24 2017
+++ setup.py    Sat Aug  5 11:32:43 2017
@@ -85,7 +85,7 @@
     link_flags = []
 else:
     flags = [
-        '-fPIC', '-std=gnu++0x', '-Wall', '-Wno-parentheses', '-Werror=switch',
+        '-fPIC', '-std=c++11', '-Wall', '-Wno-parentheses', '-Werror=switch',
     ]
     platform.mac_ver()
     if platform.system() in ['Darwin', 'FreeBSD']:

successfully builded on OpenBSD 6.1 with LLVM
clang version 4.0.0 (tags/RELEASE_400/final)
Target: amd64-unknown-openbsd6.1
Thread model: posix

@saper
Copy link
Member

saper commented Aug 5, 2017

This has to be checked if the oldest compiler we support has that option. clang 4.0 is a brand new one.

@xzyfer xzyfer added the Build label Aug 17, 2017
@xzyfer
Copy link
Contributor

xzyfer commented Aug 17, 2017

I'm personally in favour of increasing a minimum support clang/gcc versions. We'll come back around to this after 3.5.0 stable lands.

@asottile
Copy link
Member

@plavcik our project is tracked here: https://github.com/dahlia/libsass-python

@asottile
Copy link
Member

@plavcik also note that we were originally using -std=c++0x and switched to the gnu flag to fix an issue: sass/libsass-python#197

@mgreter
Copy link
Contributor

mgreter commented Sep 30, 2017

I am in favor of keeping it as is as long as it is only deprecated and not removed. Better compatibiliy with older compilers.

@asottile
Copy link
Member

tbh I can't actually find anything that says it's deprecated (googling deprecated c++0x leads to this issue in fact!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants