From 01231e2f4cf2910d0ac3a2057670829fd5b24bbd Mon Sep 17 00:00:00 2001 From: Natalie Weizenbaum Date: Wed, 6 Jan 2021 15:17:53 -0800 Subject: [PATCH] Print the values of deprecated numbers passed to color functions (#1184) See #1174 --- CHANGELOG.md | 5 +++++ lib/src/functions/color.dart | 13 ++++++++----- pubspec.yaml | 2 +- 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c22f882bb..f85df1f4a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,8 @@ +## 1.32.2 + +* Print the actual number that was received in unit deprecation warnings for + color functions. + ## 1.32.1 * Don't emit permissions errors on Windows and OS X when trying to determine the diff --git a/lib/src/functions/color.dart b/lib/src/functions/color.dart index 1f5e73520..a49ba6ff0 100644 --- a/lib/src/functions/color.dart +++ b/lib/src/functions/color.dart @@ -233,7 +233,8 @@ final module = BuiltInModule("color", functions: [ var result = _functionString("invert", arguments.take(1)); warn( - "Passing a number to color.invert() is deprecated.\n" + "Passing a number (${arguments[0]}) to color.invert() is " + "deprecated.\n" "\n" "Recommendation: $result", deprecation: true); @@ -259,7 +260,8 @@ final module = BuiltInModule("color", functions: [ if (arguments[0] is SassNumber) { var result = _functionString("grayscale", arguments.take(1)); warn( - "Passing a number to color.grayscale() is deprecated.\n" + "Passing a number (${arguments[0]}) to color.grayscale() is " + "deprecated.\n" "\n" "Recommendation: $result", deprecation: true); @@ -347,7 +349,8 @@ final module = BuiltInModule("color", functions: [ if (arguments[0] is SassNumber) { var result = _functionString("opacity", arguments); warn( - "Passing a number to color.opacity() is deprecated.\n" + "Passing a number (${arguments[0]} to color.opacity() is " + "deprecated.\n" "\n" "Recommendation: $result", deprecation: true); @@ -635,7 +638,7 @@ void _checkAngle(SassNumber angle, [String name]) { if (!angle.hasUnits || angle.hasUnit('deg')) return; var message = StringBuffer() - ..writeln("\$$name: Passing a unit other than deg is deprecated.") + ..writeln("\$$name: Passing a unit other than deg ($angle) is deprecated.") ..writeln(); if (angle.compatibleWithUnit('deg')) { @@ -667,7 +670,7 @@ void _checkPercent(SassNumber number, String name) { if (number.hasUnit('%')) return; warn( - "\$$name: Passing a number without unit % is deprecated.\n" + "\$$name: Passing a number without unit % ($number) is deprecated.\n" "\n" "To preserve current behavior: \$$name${_removeUnits(number)} * 1%", deprecation: true); diff --git a/pubspec.yaml b/pubspec.yaml index f467bdf61..b33d376a6 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,5 +1,5 @@ name: sass -version: 1.32.1 +version: 1.32.2 description: A Sass implementation in Dart. author: Sass Team homepage: https://github.com/sass/dart-sass