javax.ws.rs.client configuration?

[binakot]

I need to change default configuration of rest client, at least timeouts.
How can I change client configuration using your mailgun library?

I found this part of code:

    void configureClient(Client client) {
        //defaults to no-op
    }

    private Invocation.Builder request() {
        Client client = JerseyClientBuilder.newClient();
        configureClient(client);
        return client
                .register(configuration.httpAuthenticationFeature())
                .target(configuration.apiUrl())
                .path(configuration.domain())
                .path("messages")
                .request();
    }

JerseyClientBuilder.newClient() can take javax.ws.rs.core.Configuration as argument, but method is private and I cannot override it. Method configureClient is package-private like its class itself and I cannot extend MailForm or MailMultipart.

I need to do smth like this:

    ClientConfig configuration = new ClientConfig();
    configuration.property(ClientProperties.CONNECT_TIMEOUT, 10000);
    configuration.property(ClientProperties.READ_TIMEOUT, 30000);
    Client client = ClientBuilder.newClient(configuration);

[sargue]

Hi!

Yep, I didn't want to leak the client library (jax-rs, jersey) as much as possible. So adjusting the client directly is not currently possible.

I'm planning a 2.x version which won't depend on a single library but allow to use any (Jersey, Resteasy, Unirest) and, of course, would allow to customize it. But that's planning phase yet.

But those two timeouts could be general enough to be added to the configuration and still keep it on future versions.

Would that be enough? Are any other parameters worth adding?

[binakot]

@sargue Thanks for the quick feedback ☕️
Yep, timeouts are enough. That's because sometimes I received timeout exception on sending my emails. And large timeout helps as well.

[sargue]

Ok, that shouln't be hard to implement. Expect it in the next few days.