From 04e4ddf3cdf1a9beb37d833171695c6c90d7d7fe Mon Sep 17 00:00:00 2001
From: "hailihu@gmail.com" <Haili Hu>
Date: Wed, 9 Oct 2024 09:36:06 +0200
Subject: [PATCH] Change errorcode for Exception from -1 to 99 to fix
 visibility in Picas DB Views

---
 picas/documents.py      | 6 +++---
 picas/modifiers.py      | 4 ++--
 tests/test_document.py  | 4 ++--
 tests/test_modifiers.py | 4 ++--
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/picas/documents.py b/picas/documents.py
index d07dd04..de7757e 100644
--- a/picas/documents.py
+++ b/picas/documents.py
@@ -265,8 +265,8 @@ def error(self, msg=None, exception=None):
         if exception is not None:
             error['exception'] = traceback.format_exc()
 
-        self.doc['lock'] = -1
-        self.doc['done'] = -1
+        self.doc['lock'] = 99
+        self.doc['done'] = 99
         if 'error' not in self.doc:
             self.doc['error'] = []
         self.doc['error'].append(error)
@@ -274,7 +274,7 @@ def error(self, msg=None, exception=None):
 
     def has_error(self):
         """Bool: check if document has an error"""
-        return self.doc['lock'] == -1
+        return self.doc['lock'] == 99
 
     def get_errors(self):
         """Get document error"""
diff --git a/picas/modifiers.py b/picas/modifiers.py
index 6111bb6..5affa95 100644
--- a/picas/modifiers.py
+++ b/picas/modifiers.py
@@ -138,8 +138,8 @@ def scrub(self, token):
         return token
 
     def set_error(self, token):
-        token['lock'] = -1
-        token['done'] = -1
+        token['lock'] = 99
+        token['done'] = 99
         return token
 
 
diff --git a/tests/test_document.py b/tests/test_document.py
index 674b07e..d42c3cb 100644
--- a/tests/test_document.py
+++ b/tests/test_document.py
@@ -88,8 +88,8 @@ def test_scrub(self):
 
     def test_error(self):
         self.task.error("some message")
-        self.assertEqual(self.task['lock'], -1)
-        self.assertEqual(self.task['done'], -1)
+        self.assertEqual(self.task['lock'], 99)
+        self.assertEqual(self.task['done'], 99)
         self.task.scrub()
         self.assertEqual(self.task['lock'], 0)
         self.assertEqual(self.task['done'], 0)
diff --git a/tests/test_modifiers.py b/tests/test_modifiers.py
index 562c427..2448669 100644
--- a/tests/test_modifiers.py
+++ b/tests/test_modifiers.py
@@ -37,8 +37,8 @@ def test_scrub(self):
 
     def test_seterror(self):
         self.modifier.set_error(self.token)
-        self.assertTrue(self.token['lock'] == -1)
-        self.assertTrue(self.token['done'] == -1)
+        self.assertTrue(self.token['lock'] == 99)
+        self.assertTrue(self.token['done'] == 99)
 
     def test_addoutput(self):
         self.modifier.add_output(self.token, {"output": "test"})