Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokens that errors due to Exception not visible in Picas Database views #24

Closed
hailihu opened this issue Oct 8, 2024 · 3 comments · Fixed by #25
Closed

Tokens that errors due to Exception not visible in Picas Database views #24

hailihu opened this issue Oct 8, 2024 · 3 comments · Fixed by #25

Comments

@hailihu
Copy link
Collaborator

hailihu commented Oct 8, 2024

If an Exception is thrown during processing of a token, the token is saved in the Picas database with lock=-1 and done=-1. However, the Error view in the database assumes lock>0 && done>0, and hence the tokens are not visible here. None of the other views display these tokens either, not even overview_total.

@hailihu hailihu changed the title Tokens that error due to Exception not visible in Picas Database views Tokens that errors due to Exception not visible in Picas Database views Oct 8, 2024
@hailihu hailihu linked a pull request Oct 9, 2024 that will close this issue
@lnauta
Copy link
Member

lnauta commented Oct 9, 2024

Interesting that this was not caught before. We should ask @natalieda as this piece of code has been used since the beginning and the resulting token states are in many DBs.

@lnauta
Copy link
Member

lnauta commented Oct 10, 2024

@natalieda mentioned: "the proposed error view example was almost always modified for the user projects to reflect their applicable exit error codes, thus this has not been an issue for those who got our consultancy. But you are right that we should catch the default case for those who just follow our examples and fix this"

@lnauta
Copy link
Member

lnauta commented Oct 11, 2024

Merged #25

@lnauta lnauta closed this as completed Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants