feat(args): allow peeking arguments #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging f449e1e into 10c7a1b - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging e555294 into 10c7a1b - view on LGTM.com new alerts:
|
|
I'll have to defer to anyone who knows better about the overloading for the unreachable overload warning and how to best address it. |
|
This pull request introduces 1 alert when merging a772c84 into 10c7a1b - view on LGTM.com new alerts:
|
|
Consolidated peekWith and peek per kyra's request; this is ready for review. |
kyranet
approved these changes
Jan 2, 2021
favna
approved these changes
Jan 2, 2021
favna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
Args#peekWithandArgs#peek(alongside theirResultvariants), allowing arguments to be peeked without advancing the parser's state.Args#peekWithaccepts a callback that returns the value from eitherpickResult,repeatResult, orrestResult, saving the state before running the callback and restoring it afterwards;Args#peekis a convenience method for peeking a single argument.