feat(arguments): more descriptive error messages (#127)

Co-authored-by: Tyler J Russell <22531310+Nytelife26@users.noreply.github.com> Co-authored-by: Jeroen Claassens <support@favware.tech>
sapphiredev · Jan 3, 2021 · 04931bc · 04931bc
1 parent 9ca7456
commit 04931bc
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/arguments/CoreFloat.ts b/src/arguments/CoreFloat.ts
@@ -13,10 +13,10 @@ export class CoreArgument extends Argument<number> {
 			return this.error(argument, 'ArgumentFloatInvalidFloat', 'The argument did not resolve to a valid floating point number.');
 		}
 		if (typeof context.minimum === 'number' && parsed < context.minimum) {
-			return this.error(argument, 'ArgumentFloatTooSmall', 'The argument is too small.');
+			return this.error(argument, 'ArgumentFloatTooSmall', `The argument must be greater than ${context.minimum}.`);
 		}
 		if (typeof context.maximum === 'number' && parsed > context.maximum) {
-			return this.error(argument, 'ArgumentFloatTooBig', 'The argument is too big.');
+			return this.error(argument, 'ArgumentFloatTooBig', `The argument must be less than ${context.maximum}.`);
 		}
 
 		return this.ok(parsed);

diff --git a/src/arguments/CoreInteger.ts b/src/arguments/CoreInteger.ts
@@ -13,10 +13,10 @@ export class CoreArgument extends Argument<number> {
 			return this.error(argument, 'ArgumentIntegerInvalidNumber', 'The argument did not resolve to an integer.');
 		}
 		if (typeof context.minimum === 'number' && parsed < context.minimum) {
-			return this.error(argument, 'ArgumentIntegerTooSmall', 'The argument is too small.');
+			return this.error(argument, 'ArgumentIntegerTooSmall', `The argument must be greater than ${context.minimum}.`);
 		}
 		if (typeof context.maximum === 'number' && parsed > context.maximum) {
-			return this.error(argument, 'ArgumentIntegerTooBig', 'The argument is too big.');
+			return this.error(argument, 'ArgumentIntegerTooBig', `The argument must be less than ${context.maximum}.`);
 		}
 
 		return this.ok(parsed);

diff --git a/src/arguments/CoreString.ts b/src/arguments/CoreString.ts
@@ -8,10 +8,10 @@ export class CoreArgument extends Argument<string> {
 
 	public run(argument: string, context: ArgumentContext): ArgumentResult<string> {
 		if (typeof context.minimum === 'number' && argument.length < context.minimum) {
-			return this.error(argument, 'ArgumentStringTooShort', 'The argument is too short.');
+			return this.error(argument, 'ArgumentStringTooShort', `The argument must be greater than ${context.minimum} characters.`);
 		}
 		if (typeof context.maximum === 'number' && argument.length > context.maximum) {
-			return this.error(argument, 'ArgumentStringTooLong', 'The argument is too long.');
+			return this.error(argument, 'ArgumentStringTooLong', `The argument must be less than ${context.maximum} characters.`);
 		}
 
 		return this.ok(argument);