Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction submission to allow HW and L parameters #86

Open
drdhaval2785 opened this issue Jan 13, 2024 · 2 comments
Open

Correction submission to allow HW and L parameters #86

drdhaval2785 opened this issue Jan 13, 2024 · 2 comments

Comments

@drdhaval2785
Copy link
Contributor

Currently the user has to input these items manually. Only dict parameters are passed. If we add these parameters, the form will be autopopulated for headword snd lnum. Only old and new changes will have to be provided by the user.

https://www.sanskrit-lexicon.uni-koeln.de/scans/csl-corrections/app/correction_form.php?dict=MW&lnum=300&hw=aMSa

Something of this sort.

The use case I have in mind is that the users of downstream applications like vidyut, sanskritkosha.com, stardict files etc will have a link to submit corrections for given headword.

@funderburkjim
Copy link
Contributor

This looks plausible. 'user=xyz' might be another parameter.

Security is important.
e.g. in turning $_GET['lnum'] into $lnum.

You might consider making separate correction_form_downstream.php program (and companion correction_form_response_downstream.php).
This would allow you to experiment with this idea.

There might also be useful additional functionalities and safeguards built into c_f_ds and c_f_r_ds.
e.g. c_f_ds might require an additional 'dsapp' parameter (supplied by the app), which would be checked by c_f_r_ds to be a known downstream app.

@TempaYeshe
Copy link

That would be great! Right now the current solution to submit corrections for stardict (etc.) users is to make a PR request, i.e. something the vast majority of people on earth cannot do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants