-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to go back and forward from one user's search to another #259
Comments
By unique URL do you mean something like the following? |
@drdhaval2785 she means between she has searched for. Search history. |
yep, this should work. |
This kind of request is probably best viewed in the context of what Javascript web programmers call 'single page applications.' (SPA). Vue.js uses a special module (vue router) to implement this (see https://router.vuejs.org/). As a crude approximate explanation, Such a system hijacks the usual browser history functions (such as forward, backward arrows). I think this is purely a client-side function, and requires no special server-side hooks. A good starting place to have a display with this implementation would be one of the displays in the repository: https://github.com/funderburkjim/sanlex-vue; maybe basic v0.2b or basic v0.4 would be good starting points. Note: If anyone wants to try adding vue-router function to one of these (say basic v0.4), there is one detail regarding access of the Cologne server that should be revised (namely, there is no need currently for the 'pythonanywhere' request; pythonanywhere was used as a kluge to get around lack of https support of Cologne server; since Cologne server now is https, this kluge no longer needed). |
It's up to @artforlife if it makes sense for him. Jim, glad to see you back again! |
It might require some tweaks to the back-end as well. I cannot tell at present. @funderburkjim , are you available to answer some questions? Specifically, we need to clarify and do a couple of things on the test and production server to continue implementing things discussed in #257 |
@artforlife Ask me an easy one -- let's see how it goes. Here's one question, not sure whether for you or @drdhaval2785. We need to either This needs to be done before further work on the apidev, websanlexicon repositories is done. |
Not me @funderburkjim. As these are forks, you can safely remove / ignore those. Whenever someone needs it, he can create a new fork or use from funderburkjim repository. |
Yes, I believe I made them. I did it not in January but slightly more recently.
We should take path (b) here because it seems prudent for the repositories to be within the project. This way, pull-requests can be approved by more than one person, and there is never a hold-up due to some one being away.
Agreed. How should we proceed? CC: @gasyoun |
Fully agree. @funderburkjim how about you? |
Each dictionary entry returned as a search result should have a unique URL to make browser back&forward buttons work
The text was updated successfully, but these errors were encountered: