fix(visual-editing): execute fetches after node connect event #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rdunk
force-pushed
the
fix/comlink-status
branch
from
8ef93fb to
3bc2797
Compare
stipsan
approved these changes
Dec 16, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempted fix for this potential race condition we're seeing where sometimes features that rely on the optimistic actor aren't working as expected.
Instead of nodes fetching (via comlink) the data we need to initialise optimistic features once on app load, we instead perform these fetches each time the node status changes to
connected. The hope is that if some disconnect happens, we fetch this data when we have recovered, rather than assuming these fetches will always succeed.N.b. I haven't had time to test this one as thoroughly as I'd have liked.