Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio-only files now producing error: right-hand side of 'instanceof' is not an object #224

Closed
ghost opened this issue Mar 1, 2023 · 4 comments

Comments

@ghost
Copy link

ghost commented Mar 1, 2023

Dragging a WAV onto the video player used to work throughout the entire chain of events. I am not sure changed, but just recently now I am getting "right-hand side of 'instanceof' is not an object " when dropping a WAV onto the file upload just after it completes uploading.

@israelroldan
Copy link
Contributor

This is a regression from v2.0.10 onwards. Introduced by the upgrade of jsonwebtoken-esm to 2.x which contains a breaking change: auth0/node-jsonwebtoken#852

@israelroldan
Copy link
Contributor

@stipsan To elaborate on my comment above:

This regression was introduced by this commit from renovate: d13760f

A temporary fix is to downgrade to 2.0.9, but a structural fix is to ensure the key passed to sign the JWT is an isntance of crypto's KeyObject and not a string as currently (here) that like should most likely be: KeyObject.from(atob(signingKeyPrivate)) instead of just atob(signingKeyPrivate)

@israelroldan
Copy link
Contributor

In case anyone sees that, there's another bug in version 2.0.9. So I took a look and version 2.0.12 seems to be the last one without this problem. at least it is working for our setup. It may be of help for you @sharpsteelsoftware1

@jonabc
Copy link
Contributor

jonabc commented Jun 19, 2023

I believe this was fixed in #253. If you're still seeing this issue in recent versions please reopen 🙏

@jonabc jonabc closed this as completed Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants