Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging files with sub-chapters does not work (formerly: Merge Chapters from existing M4B files) #122

Closed
Yukigamine opened this issue Feb 1, 2021 · 8 comments

Comments

@Yukigamine
Copy link

I'm using this tool for the first time, so I apologize if the feature exists and I missed it in the documentation, but I am attempting to merge two fully chapterized M4B files into a single file and the result ends up ignoring all of their chapters and creating two chapters no names and the timestamps of the two input files.

m4b-tool merge . --no-conversion --output-file=Title.m4b

The closest parameter I found was --no-chapter-reindexing but that just results in two chapters with slightly different names.

Is there any way to important the chapter tags from M4B files that are being merged?

I'm currently running the latest build from git in Docker on WSL2. Thanks!

@Yukigamine
Copy link
Author

One other thing I noticed that may be a relic from #27 is that when using --no-conversion the "-tmpfiles" directory does not get cleaned up at the end of the process.

@sandreas
Copy link
Owner

sandreas commented Feb 2, 2021

I'll take a look in the next days.

@sandreas
Copy link
Owner

Which version are you using? Its working for me with the latest pre-release.

@Yukigamine
Copy link
Author

Yukigamine commented Feb 15, 2021

Not sure why I didn't see the email about your reply, sorry for the delay.

I was using the latest code from GitHub as of 1 Feb built into a Docker container.

Running --version reports m4b-tool v.0.4.2.

I see you've made several commits in the last few weeks, so I can try rebuilding either from the latest pre-release or the latest source.

EDIT: I see 0.4.2 is the release from 2019. So that's not very useful. That being the case, I'm not sure how else to describe my version other than built from commit 1c33feb.

@Yukigamine
Copy link
Author

Update: I figured out how to build from pre-release. I didn't realize I had to give a specific file/link in the docker build command.
I rebuilt on m4b-tool latest-127-gb61f0f8 but it's still not quite working right.

Not sure if there is a better way to show the chapters list, but I'm doing my best..
Part 1 file's chapters:
image
Part 2 file's chapters:
image
Output file:
image
image
image

What it looks like is happening is it is not offsetting the second file's chapters by the length of the first part. They'll all getting overlaid on top of each other. Because all of the chapter names are in there, just exactly where they would be if it were two separate files.

@sandreas
Copy link
Owner

Could you provide the full command line that you use?
m4b-tool merge ....

Then I can try to reproduce the problem. Thank you for your patience.

@Yukigamine
Copy link
Author

Yep, sorry for the late response.

Full command I used was:
docker run -it --rm -v "C:\path\to\book":/mnt m4b-tool merge . --no-conversion --output-file="Book.m4b")

@sandreas
Copy link
Owner

sandreas commented Jun 2, 2021

Should be fixed in the latest pre-release (see #135). Feedback would be great.

@sandreas sandreas changed the title Feature Request: Merge Chapters from existing M4B files Merging files with sub-chapters does not work (formerly: Merge Chapters from existing M4B files) Jun 2, 2021
@sandreas sandreas closed this as completed Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants