Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect AOI from pvl_singleaxis #31

Open
DanRiley opened this issue May 7, 2021 · 1 comment
Open

Incorrect AOI from pvl_singleaxis #31

DanRiley opened this issue May 7, 2021 · 1 comment

Comments

@DanRiley
Copy link
Collaborator

DanRiley commented May 7, 2021

pvl_singleaxis produces an incorrect AOI when the sun is above the earth horizon but behind the module plane.

Issue seems to be in this line of code.

Similar to issue 1221 for the python pvlib
@DanRiley
Copy link
Collaborator Author

DanRiley commented May 7, 2021

I would recommend removing lines 202 and 203, and using pvl_getaoi near the end of pvl_singleaxis to calculate the AOI without constraint. That is, AOI would have the same constraints as those placed by pvl_getaoi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DanRiley