From c9c123e5b169436d56446d8cc22901711005274f Mon Sep 17 00:00:00 2001
From: Sandesh Kumar <sandeshkr419@gmail.com>
Date: Mon, 6 Mar 2023 11:27:49 +0530
Subject: [PATCH] minor refactoring with specifying node roles

Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
---
 .idea/inspectionProfiles/Project_Default.xml                   | 3 +++
 .../opensearch/action/admin/cluster/stats/ClusterStatsIT.java  | 3 ++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/.idea/inspectionProfiles/Project_Default.xml b/.idea/inspectionProfiles/Project_Default.xml
index 5cf789707c58c..78b8edcfe216e 100644
--- a/.idea/inspectionProfiles/Project_Default.xml
+++ b/.idea/inspectionProfiles/Project_Default.xml
@@ -1,6 +1,9 @@
 <component name="InspectionProjectProfileManager">
   <profile version="1.0">
     <option name="myName" value="Project Default" />
+    <inspection_tool class="AutoCloseableResource" enabled="true" level="WARNING" enabled_by_default="true">
+      <option name="METHOD_MATCHER_CONFIG" value="java.util.Formatter,format,java.io.Writer,append,com.google.common.base.Preconditions,checkNotNull,org.hibernate.Session,close,java.io.PrintWriter,printf,java.io.PrintStream,printf,org.opensearch.test.OpenSearchIntegTestCase,internalCluster" />
+    </inspection_tool>
     <inspection_tool class="GroovyPointlessBoolean" enabled="false" level="WARNING" enabled_by_default="false" />
     <inspection_tool class="PointlessBooleanExpression" enabled="false" level="WARNING" enabled_by_default="false">
       <option name="m_ignoreExpressionsContainingConstants" value="true" />
diff --git a/server/src/internalClusterTest/java/org/opensearch/action/admin/cluster/stats/ClusterStatsIT.java b/server/src/internalClusterTest/java/org/opensearch/action/admin/cluster/stats/ClusterStatsIT.java
index f1f2ede79220e..a2c0e8458481a 100644
--- a/server/src/internalClusterTest/java/org/opensearch/action/admin/cluster/stats/ClusterStatsIT.java
+++ b/server/src/internalClusterTest/java/org/opensearch/action/admin/cluster/stats/ClusterStatsIT.java
@@ -335,7 +335,8 @@ public void testNodeRolesWithMasterLegacySettings() throws ExecutionException, I
     public void testNodeRolesWithClusterManagerRole() throws ExecutionException, InterruptedException {
         int total = 1;
         Settings legacyMasterSettings = Settings.builder()
-            .put("node.roles", "cluster_manager, remote_cluster_client").build();
+            .put("node.roles", String.format("%s, %s", DiscoveryNodeRole.CLUSTER_MANAGER_ROLE.roleName(), DiscoveryNodeRole.REMOTE_CLUSTER_CLIENT_ROLE.roleName()))
+            .build();
 
         internalCluster().startNodes(legacyMasterSettings);
         waitForNodes(total);