Fix restoring intensity when showing a multi-channel image with deselected channels #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The brightness control uses the same limits as for the intensity controls and should therefore use large range sliders as well.
Now that the image adjustment sliders allow the full range, the limits no longer need to be adapted when switching controls for another image.
The image overlayer expects all channel settings to be given in absolute rather than relative position, but the PlotEditor has supplied them relative to only the images shown. If a preceding channel was deselected, prior channel-specific settings would be given at the incorrect index and either applied to the wrong channel or ignored if the channel was not shown. Fix by converting these settings to absolute channel order for the overlayer. Update the overlayer docs to clarify the expected channel order.
- Add a parameter to accept 3D+ vs 5D images - Add unit testing script for `np_io` module, starting with this function - Use this function when setting up images in the PlotEditor
Fix arguments for 3D images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image overlayer expects all channel settings to be given in absolute rather than relative position, but the PlotEditor has supplied them relative to only the images shown. If a preceding channel was deselected, prior channel-specific settings would be given at the incorrect index and either applied to the wrong channel or ignored if the channel was not shown. Fix by converting these settings to absolute channel order for the overlayer. Update the overlayer docs to clarify the expected channel order.
This PR includes fixes for #572 and additional changes:
-Fix changing slider limits
np_iomodule