Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump default Python version to v3.9 #559

Merged
merged 10 commits into from
Sep 25, 2023
Merged

Bump default Python version to v3.9 #559

merged 10 commits into from
Sep 25, 2023

Conversation

yoda-vid
Copy link
Collaborator

Fixes #557, #558.

Update the default Python version to v3.9 now that NumPy and many related packages have dropped support for Python 3.8 (see https://numpy.org/neps/nep-0029-deprecation_policy.html). This testing revealed a number of issues related to Matplotlib v3.8 now that it can be installed with this version of Python, fixed in this PR.

- Avoid runtime error by raising a file not found exception
- Fix typo in swarm plot doc
Warn if unable to set up the style.
The `seaborn[-x]` format styles were removed in Matplotlib 3.8 (see https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.8.0.html#removal-of-deprecated-apis), leading to an error when attempting to set this style in the main GUI. Simply use the default style instead since appears to work well for the Atlas and ROI Editors.
In Matplotlib 3.8, setting up a linear segmented colormap with colors given as a tuple gives an error that the color is not valid, eg `ValueError: 'k' is not a valid color value.` Fix by change the tuple to a list.
Prep for updating the default configuration to Python 3.9 by adding an environment specific to Python 3.8.
Update to Python 3.9 now that NumPy and many related packages have dropped support for Python 3.8 (see https://numpy.org/neps/nep-0029-deprecation_policy.html).
@yoda-vid yoda-vid added bug Something isn't working dependencies Issues/requests related to a dependency package labels Sep 21, 2023
@yoda-vid yoda-vid added this to the v1.6.0 milestone Sep 21, 2023
@yoda-vid yoda-vid self-assigned this Sep 21, 2023
@yoda-vid yoda-vid merged commit 3e389f3 into master Sep 25, 2023
36 checks passed
@yoda-vid yoda-vid deleted the fix_for_py39 branch September 25, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Issues/requests related to a dependency package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error loading style in Matplotlilb >= v3.8
1 participant