Replace default hotkey with Shift+Pause #1337
Conversation
There was a problem hiding this comment.
VK_CANCEL = 0x03 Break
VK_PAUSE = 0x13 Pause
are the Microsoft virtual key codes.
Pause = Shift+Break
Shift key is needed for Pause on my keyboard.
Ctrl+Alt+Cancel = Ctrl+Alt+Break
might be compatible.
Cancel is probably an unusual key text, though probably correct translated virtual key code. If Break can be substituted for Cancel, then that might be better. I have not seen a Cancel key on a Querty keyboard, perhaps it is a Apple thing.
I am not sure of a literal key text for virtual key codes for Qt. @DavidXanatos may have better insight with this topic with the text return from QKeyEvent::text().
References:
|
Cancel can't surely stay as it is, because it conflicts with the italian translation of the Cancel button on the UI (which is totally another thing for another purpose). If Break is more correct than Pause, then so be it, I can apply the change right now. |
|
@NewKidOnTheBlock |
|
Hehe. We already talked about this here: #965 |
|
Changing the sequence string will not help, the string tells the hotkey library on which key to listen if you change it it will just not work, you can test it by pressing key combinations and see what the entry windows makes out of it |
If you set Italian language on Plus and then try to apply manually Ctrl+Alt+Pause on the UI box, that would be incorrectly displayed as Ctrl+Alt+Annulla. Annulla is the italian translation of the Cancel button related to dialogs, which can assume a different meaning on my language. This is why Cancel cannot be associated to a Pause/Break button or at least not translated as the Cancel button on the UI dialogs. |
|
You can play around with what Qt thinks of different key combinations by clicking in the QKeySequenceEdit that takes the combination and pressing various keys and key combinations. break: Pause there is soemthign somehow screwed up in how Qt interpretes the key codes, and I don't think its a good use of my time to fork the QKeySequenceEdit |
It looks like you're right, Qt really screwed up certain combination keys. I've just tested At this point, I would propose to choose Other working alternatives that I tested: Shift+P, Alt+Pause, Shift+T... any comment would be appreciated. |
|
Well I personally prefer ctrl + break, but its a problematic combination you cant even re enter it properly, strangely enough ctrl+scrol lock enters ctrl+cancel... so given that its so widely inconsistent i think shift + break is a good alternative indeed. So lets do that :) |
This is only related to Plus UI.
The
Cancelreference related to the default hotkey is automatically translated on the Plus UI as it was a Cancel button for dialogs. This conflict (partially due to how Qt interpretes the key codes) would be fixed by replacing the defaultCtrl+Alt+CancelwithShift+Pauseor other alternatives I proposed here.