Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A space is missing in the German translation during installation #1333

Closed
Dyras opened this issue Oct 25, 2021 · 8 comments
Closed

A space is missing in the German translation during installation #1333

Dyras opened this issue Oct 25, 2021 · 8 comments
Labels
Sbie Installer Sandboxie installer Status: Fixed in Next Build Fixed in the next Sandboxie version Type: Localization Localization/translation issues

Comments

@Dyras
Copy link
Contributor

Dyras commented Oct 25, 2021

Hello! I'm not filling out this form because this is a 5 sec issue, if that's OK?

grafik
"Starte automatischSandboxie-Plus" is what it says. However it should definitely say
"Starte automatisch Sandboxie-Plus"
(A space is missing)

@Dyras Dyras changed the title A space is missing in the German translation A space is missing in the German translation during installation Oct 25, 2021
@isaak654
Copy link
Collaborator

isaak654 commented Oct 25, 2021

It looks like the error is located on the Inno Setup repository, so a new pull request is needed there:
https://github.com/jrsoftware/issrc/blob/15db6745cd5480d06710a287afbf0ba8d45f6034/Files/Languages/German.isl#L404

P.S. It is related to the Sandboxie Plus installer, but this repository is not directly involved. Maybe the fixed line could be temporarily added on our Languages.iss file, but I would like to ask an opinion about it.

@isaak654 isaak654 added the Sbie Installer Sandboxie installer label Oct 25, 2021
@mpheath
Copy link
Collaborator

mpheath commented Oct 25, 2021

As isaak654 mentions, German.isl contains the issue.

Even if updated upstream, the fix would not be available until the new released version of Inno Setup is used for the compile. So, a temporary override in Languages.iss could be added until German.isl is fixed.

A fix for Languages.iss has been commited: 3fb7d8e

@mpheath mpheath added the Status: Fixed in Next Build Fixed in the next Sandboxie version label Oct 25, 2021
@isaak654
Copy link
Collaborator

isaak654 commented Oct 25, 2021

@mpheath
It's also quite amazing that they requested you to sign a license agreement for another minor typo fix in your pull request there.

@mpheath
Copy link
Collaborator

mpheath commented Oct 25, 2021

@isaak654
Yeah, not very friendly. I always think twice before signing something as you can be put into a legal conflict. The PR is just to fix a typo. I do not expect German,isl to be fixed too soon.

@bastik-1001
Copy link
Collaborator

Of course it is wrong to have the name being written next to the string without there being a space.

I am not even sure that the fix is sorting it out from a grammatical point of view.

Automatically start %1

turns to

Starte automatisch %1

while it would be better if it would be

Starte %1 automatisch

so that it reads Starte Sandboxie-Plus automatisch

Alternatively one could have

%1 automatisch starten

to have it read Sandboxie Plus automatisch starten

or

Automatisch starten: %1

Those would allow users to be able to read it without there being a grammatical 'concern'.

@mpheath
Copy link
Collaborator

mpheath commented Oct 31, 2021

@bastik-1001

Alternatively one could have

%1 automatisch starten

Same as dutch, is that preferred grammer as the temporary fix in Languages.iss?

These are AutoStartProgram translations:

Language Custom Message
english Automatically start %1
ChineseSimplified 自动启动 %1
ChineseTraditional 自動開啟 %1
dutch %1 automatisch starten
french Démarrer automatiquement %1
german Starte automatisch%1
italian Esegui automaticamente %1
polish Automatycznie uruchamiaj aplikację %1
portuguese Iniciar %1 automaticamente
russian Автоматически запускать %1
spanish Iniciar automáticamente %1
  • dutch and german are similar.
  • portuguese and spanish are similar.

What this shows is that the order of the words can vary.

@isaak654 isaak654 added the Type: Localization Localization/translation issues label Jan 16, 2022
@martijnlaan
Copy link

@mpheath It's also quite amazing that they requested you to sign a license agreement for another minor typo fix in your pull request there.

It's an automated process which is commonly used in many repositories.

@isaak654
Copy link
Collaborator

It's an automated process which is commonly used in many repositories.

In fact, I have changed my mind since then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sbie Installer Sandboxie installer Status: Fixed in Next Build Fixed in the next Sandboxie version Type: Localization Localization/translation issues
Projects
None yet
Development

No branches or pull requests

6 participants