Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureRequest: check manual changes on page before overwriting it #4

Open
no-one2k opened this issue Mar 6, 2020 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@no-one2k
Copy link

no-one2k commented Mar 6, 2020

Case:

  1. we made jupyter notebook and linked it to confluence page
  2. we commited it for the first time, so now page and notebook are synchronized
  3. someone manually modified page
  4. we modified notebook and commited it => manual changes will be lost (that's probably okay) and nobody will know about it (that's not okay)

So it would be nice to check before commiting notebook if page was manually changed and ask a confirmation.

@sancau sancau added the enhancement New feature or request label Mar 6, 2020
@sancau sancau self-assigned this Mar 6, 2020
@sancau
Copy link
Owner

sancau commented Mar 6, 2020

Actully the manual changes won't be lost completely as there is version history in Confluence intself.
Still, I think that's a nice thing to have (a warning on push). At the moment we are limited by the nbconflux library in our interaction with Confluence and I suppose it doesn't have such feature.

I'm going to check out if there's a relatively easy and straightforward way to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants