Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRT Files Download as VTT #467

Closed
4 tasks
joncameron opened this issue Apr 2, 2024 · 2 comments
Closed
4 tasks

SRT Files Download as VTT #467

joncameron opened this issue Apr 2, 2024 · 2 comments
Assignees

Comments

@joncameron
Copy link
Contributor

joncameron commented Apr 2, 2024

Description

Avalon's /captions route is automatically transforming SRT files to VTT for display in the client. The download from Ramp is in turn returning a VTT instead of the original SRT when a user downloads from the Transcript component. When downloading from the Ramp Transcript component, the original SRT file should be the one downloaded to the client.

Implementation Strategy

  • Captions are added as two annotations: supplementing (display in player, currently used), and rendering (to be used for download) - SRT Files Download as VTT avalonmediasystem/avalon#5725
    • Files component only shows rendering annotation
    • Supplemental file URL serialized into the manifest as an rendering annotation

That what we would show in Ramp would be set as 'rendering' would work with the ethos of IIIF.

Done Looks Like

  • Ramp only displays the supplementing caption in the player
  • Ramp only displays the rendering caption in the Files/Supplemental Files component
  • Supplementing annotations do not display in the Files/Supplemental Files component
  • Update Ramp documentation - this will change existing behavior for the Supplemental Files component

Notes

  • Route for captions: supplemental_files/sdfli2398/captions # referenced in manifest
  • Captions endpoint is only returning VTT
  • supplemental_files/sdfli2398 should return the original SRT
@charumitraravi
Copy link
Collaborator

charumitraravi commented May 16, 2024

I tested this item and I am able to download srt captions in the original format. However, these are the following issues I encountered with srt transcripts:

  1. When I try to access an item that only has an SRT transcript (for example, this page), the webpage crashes.

  2. If a media item has multiple transcripts available and one of them is an SRT file, the page also crashes when I select the SRT transcript from the list (as seen in this example).
    (refer the screenshots attached)

Screenshot 2024-05-16 at 7 45 08 PM Screenshot 2024-05-16 at 7 47 59 PM

These issues are not happening in avalon-staging

@joncameron
Copy link
Contributor Author

SRT bug issue: #489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants