Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume and Quality Selector Resets to Default On Each Canvas Change #390

Closed
joncameron opened this issue Feb 7, 2024 · 8 comments · Fixed by #395
Closed

Volume and Quality Selector Resets to Default On Each Canvas Change #390

joncameron opened this issue Feb 7, 2024 · 8 comments · Fixed by #395
Assignees

Comments

@joncameron
Copy link
Contributor

Description

@joncameron joncameron changed the title Volume Resets to Default On Each Canvas Chagne Volume Resets to Default On Each Canvas Change Feb 7, 2024
@cjcolvar cjcolvar self-assigned this Feb 7, 2024
@elynema
Copy link

elynema commented Feb 8, 2024

@cjcolvar Apparently video quality selection is supposed to be remembered as well. Is that easy to add as part of this?

@cjcolvar
Copy link
Member

cjcolvar commented Feb 9, 2024

👍 I have both in my PR to ramp.

@elynema elynema changed the title Volume Resets to Default On Each Canvas Change Volume and Quality Selector Resets to Default On Each Canvas Change Feb 9, 2024
@elynema
Copy link

elynema commented Feb 12, 2024

Testing: test this in both media item and playlist context

@elynema elynema reopened this Feb 13, 2024
@elynema
Copy link

elynema commented Feb 14, 2024

Tested on Ramp demo site in playlist and media item context in Safari and Chrome on macOS as well as Chrome on Android and Safari on iPad. Note that volume cannot be adjusted on mobile devices, so only quality selector is relevant there.

@cjcolvar @joncameron Volume is retained, but not mute. So if a user mutes the canvas, the next canvas is un-muted. Settings are also retained across records, not just canvases. If I load a new manifest into Ramp, it remembers volume level and quality selection from the last canvas.

@cjcolvar
Copy link
Member

I'll take a look at mute.
The current approach of storing in localStorage thus making the setting sticky for a potentially really long time is the same as in Avalon 7.6/MCO. I guess how long it stays around right now is dependent on when the browser clears out localStorage, but I guess we could try to tie it to session within Avalon and have localStorage get wiped on logout.

@elynema
Copy link

elynema commented Feb 14, 2024

@joncameron @cjcolvar To be clear, I'm ok with the settings being sticky across records as long as localStorage lasts. I just wanted to note that was happening in case anyone else had an issue with it. Given that if the user changes volume, the new level is sticky, I really don't see it being an issue.

@elynema
Copy link

elynema commented Feb 14, 2024

@cjcolvar Looks like mute is not being retained when switching from a video to an audio canvas on Chrome on Android or Safari on iPhone. Quality level is being retained.

Safari and Chrome on macOS handled the mute fine.

@joncameron
Copy link
Contributor Author

@cjcolvar Can you take a quick look and see if the mobile issue is a potentially easy fix? Otherwise I'll close this issue and create a bug ticket just for the Android and iOS behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants