-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Volume and Quality Selector Resets to Default On Each Canvas Change #390
Comments
@cjcolvar Apparently video quality selection is supposed to be remembered as well. Is that easy to add as part of this? |
👍 I have both in my PR to ramp. |
Testing: test this in both media item and playlist context |
Tested on Ramp demo site in playlist and media item context in Safari and Chrome on macOS as well as Chrome on Android and Safari on iPad. Note that volume cannot be adjusted on mobile devices, so only quality selector is relevant there. @cjcolvar @joncameron Volume is retained, but not mute. So if a user mutes the canvas, the next canvas is un-muted. Settings are also retained across records, not just canvases. If I load a new manifest into Ramp, it remembers volume level and quality selection from the last canvas. |
I'll take a look at mute. |
@joncameron @cjcolvar To be clear, I'm ok with the settings being sticky across records as long as localStorage lasts. I just wanted to note that was happening in case anyone else had an issue with it. Given that if the user changes volume, the new level is sticky, I really don't see it being an issue. |
@cjcolvar Looks like mute is not being retained when switching from a video to an audio canvas on Chrome on Android or Safari on iPhone. Quality level is being retained. Safari and Chrome on macOS handled the mute fine. |
@cjcolvar Can you take a quick look and see if the mobile issue is a potentially easy fix? Otherwise I'll close this issue and create a bug ticket just for the Android and iOS behavior. |
Description
The text was updated successfully, but these errors were encountered: