Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined Error for Manifest with No Items #346

Closed
1 task done
joncameron opened this issue Jan 18, 2024 · 2 comments
Closed
1 task done

Undefined Error for Manifest with No Items #346

joncameron opened this issue Jan 18, 2024 · 2 comments
Assignees
@Dananji

Comments

@joncameron
Copy link
Contributor

joncameron commented Jan 18, 2024 •
edited by Dananji
Loading

Description

An example manifest from Tanya Clement that contains no items is resulting in a fatal error in Ramp when loaded.

To Reproduce

Done Looks Like

  • Information in the manifest is populated to the corresponding components when there is no item present in the manifest
@joncameron
Copy link
Contributor Author

Need to fail gracefully when there's a body and duration but no content.

@Dananji Dananji self-assigned this Feb 20, 2024
@Dananji Dananji mentioned this issue Feb 21, 2024
Merged
@joncameron
Copy link
Contributor Author

I now see the "This item cannot be played." message instead of the error on the Ramp demo site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dananji Dananji

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dananji @joncameron