-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structured navigation component should auto-scroll so that active section is visible to users #289
Comments
When auto-scroll happens there's a re-render and this could possibly cause jerky behavior as was seen before, but we might be able to avoid these. |
@joncameron Let's see what Dananji says, but I think that section switching is a core part of this and we should just bring this issue back to in progress to keep the work together in one place. |
@Dananji Pulling this back to In Progress as the auto-scroll is not working when a section is selected. |
Implementation pulls the selected section to the very middle of the structured navigation display. I believe that resolves the requirements of this issue, although it is still a bit confusing as after clicking on a section, the user is pulled back up to the top of the page to show the player and so the selected section moves below the fold (depending on the size of your screen). Verified that structured nav component is auto-scrolling as the item auto-plays as well. |
If we implement auto-scrolling the page to show the structured navigation into view, it might cause the page to scroll causing the jerky behavior we were seeing before. |
Description
Since the structured navigation component is now a scrollable element, it seems desirable for it to auto-scroll so that the currently active / playing section is visible in the viewport (aka, viewable to users). Since users can't see the structured navigation component if they are scrolled to the top of the screen, this means that if they scroll down to see the structured navigation component, they should see the currently playing section highlighted without having to scroll within the component itself.
The component should advance automatically as sections advance via auto-play.
Done Looks Like
The text was updated successfully, but these errors were encountered: