Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain Focus After Selecting Next or Previous Buttons #274

Closed
1 task done
joncameron opened this issue Oct 30, 2023 · 3 comments
Closed
1 task done

Retain Focus After Selecting Next or Previous Buttons #274

joncameron opened this issue Oct 30, 2023 · 3 comments
Assignees
@Dananji @charumitraravi

Comments

@joncameron
Copy link
Contributor

joncameron commented Oct 30, 2023 •
edited by elynema
Loading

Description

When a user uses the keyboard to focus on the previous or next buttons and selects them by pressing enter, the context of the currently selected element is lost. Ramp should retain the current focused element when events occur within the components.

Done Looks Like

  • Focus is retained on previous and next canvas buttons in media player after they are selected and events occur

Current Behavior

next_button.mp4
@joncameron joncameron mentioned this issue Oct 30, 2023
Closed
7 tasks
@joncameron joncameron reopened this Oct 31, 2023
@joncameron joncameron changed the title Retain Focus After Selected Next or Previous Buttons Retain Focus After Selecting Next or Previous Buttons Oct 31, 2023
@joncameron
Copy link
Contributor Author

There may be video.js properties we can use here.

@Dananji Dananji self-assigned this Nov 13, 2023
@Dananji
Copy link
Collaborator

Dananji commented Nov 15, 2023

Not in avalon-dev yet, but can be tested on the Ramp demo site.

@Dananji Dananji mentioned this issue Nov 29, 2023
Merged
@charumitraravi
Copy link
Collaborator

QA completed on avalon dev

@elynema elynema closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dananji Dananji

@charumitraravi charumitraravi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Dananji @joncameron @charumitraravi @elynema