From 2d62afc143ab13f67ae2f372d98bd11cf6e19d53 Mon Sep 17 00:00:00 2001
From: Sameeksha Vaity <sameeksha.v91@gmail.com>
Date: Wed, 2 Jun 2021 15:14:54 -0700
Subject: [PATCH] Update Changelog (#7)

---
 .../azure-ai-metricsadvisor/CHANGELOG.md      | 11 +++++++--
 .../models/AnomalyIncident.java               | 24 +++++++++----------
 .../src/main/java/module-info.java            |  1 +
 3 files changed, 22 insertions(+), 14 deletions(-)

diff --git a/sdk/metricsadvisor/azure-ai-metricsadvisor/CHANGELOG.md b/sdk/metricsadvisor/azure-ai-metricsadvisor/CHANGELOG.md
index a9e105181d07f..3ee5596ac09c3 100644
--- a/sdk/metricsadvisor/azure-ai-metricsadvisor/CHANGELOG.md
+++ b/sdk/metricsadvisor/azure-ai-metricsadvisor/CHANGELOG.md
@@ -3,11 +3,18 @@
 ## 1.0.0-beta.4 (Unreleased)
 
 ### Features added
-- Added support for Azure Log Analytics DataFeed source.
+- Added support for Azure Log Analytics DataFeed source
+- Added data source credential API support to client
+- Added authentication type support for data feed
+- Added property `splitAlertByDimensions` to AnomalyAlertConfiguration model
 
 ### Breaking changes
+- Replaced updateSubscriptionKey and updateApiKey into one method updateKey
+- Deprecated support for HttpRequestDataFeed and ElasticsearchDataFeed source type
+- Renamed `value` and `expectedValue` to `valueOfRootNode` and `expectedValueOfRootNode`
 - Renamed `top` parameter to `maxPageSize`
-
+- Removed granularity type DataFeedGranularityType.PerSecond as it's not supported by the service anymore.
+  
 ## 1.0.0-beta.3 (2021-02-09)
 - Support Azure Active Directory (AAD) authentication for Metrics Advisor clients. 
 - Renamed method `listDimensionValuesWithAnomalies` and `ListDimensionValuesWithAnomaliesOptions`.
diff --git a/sdk/metricsadvisor/azure-ai-metricsadvisor/src/main/java/com/azure/ai/metricsadvisor/models/AnomalyIncident.java b/sdk/metricsadvisor/azure-ai-metricsadvisor/src/main/java/com/azure/ai/metricsadvisor/models/AnomalyIncident.java
index 7eb707bfa0495..62da6421c2181 100644
--- a/sdk/metricsadvisor/azure-ai-metricsadvisor/src/main/java/com/azure/ai/metricsadvisor/models/AnomalyIncident.java
+++ b/sdk/metricsadvisor/azure-ai-metricsadvisor/src/main/java/com/azure/ai/metricsadvisor/models/AnomalyIncident.java
@@ -21,8 +21,8 @@ public final class AnomalyIncident {
     private AnomalyIncidentStatus status;
     private OffsetDateTime startTime;
     private OffsetDateTime lastTime;
-    private Double value;
-    private Double expectedValue;
+    private Double valueOfRootNode;
+    private Double expectedValueOfRootNode;
 
     static {
         IncidentHelper.setAccessor(new IncidentHelper.IncidentAccessor() {
@@ -53,12 +53,12 @@ public void setRootDimensionKey(AnomalyIncident incident, DimensionKey rootDimen
 
             @Override
             public void setValue(AnomalyIncident incident, Double value) {
-                incident.setValue(value);
+                incident.setValueOfRootNode(value);
             }
 
             @Override
             public void setExpectedValue(AnomalyIncident incident, Double value) {
-                incident.setExpectedValue(value);
+                incident.setExpectedValueOfRootNode(value);
             }
 
             @Override
@@ -136,8 +136,8 @@ public DimensionKey getRootDimensionKey() {
      *
      * @return The value.
      */
-    public Double getValue() {
-        return this.value;
+    public Double getValueOfRootNode() {
+        return this.valueOfRootNode;
     }
 
     /**
@@ -145,8 +145,8 @@ public Double getValue() {
      *
      * @return The expected value.
      */
-    public Double getExpectedValue() {
-        return this.expectedValue;
+    public Double getExpectedValueOfRootNode() {
+        return this.expectedValueOfRootNode;
     }
 
     /**
@@ -205,12 +205,12 @@ void setRootDimensionKey(DimensionKey rootDimensionKey) {
         this.rootDimensionKey = rootDimensionKey;
     }
 
-    void setValue(Double value) {
-        this.value = value;
+    void setValueOfRootNode(Double valueOfRootNode) {
+        this.valueOfRootNode = valueOfRootNode;
     }
 
-    void setExpectedValue(Double value) {
-        this.expectedValue = value;
+    void setExpectedValueOfRootNode(Double value) {
+        this.expectedValueOfRootNode = value;
     }
 
     void setSeverity(AnomalySeverity severity) {
diff --git a/sdk/metricsadvisor/azure-ai-metricsadvisor/src/main/java/module-info.java b/sdk/metricsadvisor/azure-ai-metricsadvisor/src/main/java/module-info.java
index 1257368814eb4..1556f922b0ddd 100644
--- a/sdk/metricsadvisor/azure-ai-metricsadvisor/src/main/java/module-info.java
+++ b/sdk/metricsadvisor/azure-ai-metricsadvisor/src/main/java/module-info.java
@@ -9,6 +9,7 @@
     exports com.azure.ai.metricsadvisor.administration;
 
     opens com.azure.ai.metricsadvisor.implementation to com.fasterxml.jackson.databind;
+    opens com.azure.ai.metricsadvisor.administration.models to com.fasterxml.jackson.databind;
     opens com.azure.ai.metricsadvisor.models to com.fasterxml.jackson.databind;
     opens com.azure.ai.metricsadvisor.implementation.models to com.fasterxml.jackson.databind, com.azure.core;
 }