-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix python_requires
metadata to require >=3.6.1
#2306
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2306 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 23 23
Lines 4477 4477
Branches 903 903
=======================================
Hits 4476 4476
Misses 1 1 Continue to review full report at Codecov.
|
seems reasonable to me. Please can you:
|
I guess the best explanation for this is given by Guido van Rossum https://bugs.python.org/issue29011#msg283660 |
Is there a predefined process for this? Couldn't find anything in the docs |
Ok I found the changelog process here. Maybe the contribution docs should link there? |
That's very weird, thanks for hunting it down.
The PR template that you should have seen when creating the PR describes it pretty well, that's enough mostly. Happy to accept a PR to update the contributing docs, otherwise I'll try to make it clearer when I get around to it. |
Thanks a lot fo this. |
At least this
typing.Deque
import requires Python version to be >=3.6.1.This PR fixes
python_requires
metadata.