Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nan type #54

Closed
samuelcolvin opened this issue Oct 11, 2022 · 6 comments
Closed

nan type #54

samuelcolvin opened this issue Oct 11, 2022 · 6 comments

Comments

@samuelcolvin
Copy link
Owner

Since float('nan') != float('nan') we need a custom FloatNan type.
@samuelcolvin
Copy link
Owner Author

inf/-inf too?

@FBruzzesi
Copy link
Contributor

Hi @samuelcolvin, if there is still interest in this issue I can take it!
Any drawback in using math.isnan and math.isinf for the checks?

@samuelcolvin
Copy link
Owner Author

definitely still interest, no drawback I know of to math.isnan.

I guess we have FloatNan, FloatInfPos, FloatInfNeg?

@FBruzzesi
Copy link
Contributor

I would consider a more general FloatInf as well (that's the use case it brought me here in the first place).

Just to make sure on naming convention, they should all have a Is prefix, correct?

@samuelcolvin
Copy link
Owner Author

Sorry, yes Is prefix.

FloatInf is fine by me.

@FBruzzesi FBruzzesi mentioned this issue Mar 22, 2023
Merged
@alexmojaki
Copy link
Contributor

This is done, yes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexmojaki @samuelcolvin @FBruzzesi