From 38bfe65c90e9f695d6f08b37c845c487153f41b8 Mon Sep 17 00:00:00 2001 From: Louis Bergelson Date: Sun, 17 Feb 2019 21:39:52 -0500 Subject: [PATCH] moving HttpUtilsTest to externalApi test task (#1289) * HttpUtilsTest is flakey because it connects to remote web servers. Moved it to the testExternalAPIs test task * changed a broken link so that the tests pass again --- build.gradle | 4 +++- src/test/java/htsjdk/samtools/util/HttpUtilsTest.java | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/build.gradle b/build.gradle index 6b272c171b..d525875540 100644 --- a/build.gradle +++ b/build.gradle @@ -109,6 +109,7 @@ test { exclude "broken" exclude "defaultReference" exclude "ftp" + exclude "http" exclude "sra" exclude "ena" @@ -127,11 +128,12 @@ task testFTP(type: Test) { } task testExternalApis(type: Test) { - description = "Run the SRA and ENA tests (tests that interact with external APIs)" + description = "Run the SRA, ENA, and HTTP tests (tests that interact with external APIs)" jvmArgs += '-Dsamjdk.sra_libraries_download=true' tags { include "sra" + include "http" include "ena" exclude "slow" exclude "broken" diff --git a/src/test/java/htsjdk/samtools/util/HttpUtilsTest.java b/src/test/java/htsjdk/samtools/util/HttpUtilsTest.java index b759445802..827771f867 100644 --- a/src/test/java/htsjdk/samtools/util/HttpUtilsTest.java +++ b/src/test/java/htsjdk/samtools/util/HttpUtilsTest.java @@ -8,12 +8,13 @@ import htsjdk.HtsjdkTest; +@Test(groups = "http") public class HttpUtilsTest extends HtsjdkTest { @DataProvider(name = "existing_urls") public Object[][] testExistingURLsData() { return new Object[][]{ {"http://broadinstitute.github.io/picard/testdata/index_test.bam"}, - {"http://ftp.1000genomes.ebi.ac.uk/vol1/ftp/current.tree"} + {"http://ftp.1000genomes.ebi.ac.uk/vol1/ftp/README_using_1000genomes_cram.md"} }; }