Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better lock acquisition failure notification #24

Closed
japm opened this issue Jul 28, 2017 · 1 comment
Closed

Better lock acquisition failure notification #24

japm opened this issue Jul 28, 2017 · 1 comment

Comments

@japm
Copy link

japm commented Jul 28, 2017

In case of unreachable Redis servers, the library is returning lock not aquired
if a maiority is not obtained.

The situation should be notified to the user, so it can react to this different situation,
and ignore the lock status if convenient for its purposes.

@samcook
Copy link
Owner

samcook commented Feb 13, 2018

Hi,

I've done some changes on the feature/redlock-status branch and pushed a new pre-release package 2.1.0-pre1.

This includes a RedLockFactory.ConfigurationChanged event that is fired whenever any changes are detected to the underlying redis connections.

There are also two new properties on the RedLock object:

  • Status is an enum that gives more detail that the existing IsAcquired boolean about whether the lock is acquired, or why it isn't.
  • InstanceSummary contains details on the number of redis instances the lock was acquired/conflicted/errored in.

If you'd like to try out this version any feedback is appreciated.

@samcook samcook changed the title Redis Down Better lock acquisition failure notification Feb 13, 2018
@samcook samcook closed this as completed Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants