-
-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keys: accept multiple maps (vaargs) #452
Comments
Hey @samber I want to add a PR to resolve this issue. Can I get access to adding a PR for this issue ?? Also, I can see the Test of Keys is incorrect as it sorts the keys before asserting them, but there is no sort in the Keys function. I will also fix them. |
@ccoVeille I want to be a contributor. Can you help me to get access? I can fix this issue and some other open issues. |
I don't have much access than you do I think. I'm just a compulsive code reviewer. That's why you see me active. You just have to fork the repository, push a branch on it, then open a PR mentioning the issue you want to fix. I can review a PR if you open one. |
@ccoVeille by seeing your code reviews, I was amazed at how much good you are doing. I would love to chat with you one day. Can you also review my PR? |
you are nice, thanks. You can join the slack workspace of the gophers. You will find the link on my GitHub profile. So we can talk there Edit: here is the link https://gophers.slack.com/team/U03FE6TMKPX |
Hello @ccoVeille how do I join the gophers slack channel? |
Click on the link I provided, create an account if needed, install slack if needed. If it doesn't work, try with this link https://join.slack.com/t/gophers/shared_invite/zt-2lmem2ic2-EfbtKK9FGlBHHgeEu0an7Q The link is valid for 4 days cc @dagenius007 |
From
to
In case of collision, deduplicate keys?
The text was updated successfully, but these errors were encountered: