Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3006.x][Batch 13] Increase code coverage on state module saltmod #65372

Merged
merged 12 commits into from
Oct 16, 2023
Merged

[3006.x][Batch 13] Increase code coverage on state module saltmod #65372

merged 12 commits into from
Oct 16, 2023

Conversation

s0undt3ch
Copy link
Collaborator

What does this PR do?

See title

@s0undt3ch s0undt3ch requested a review from a team as a code owner October 10, 2023 12:06
@s0undt3ch s0undt3ch requested review from twangboy and removed request for a team October 10, 2023 12:06
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [Batch 13] Increase code coverage on state module saltmod [3006.x][Batch 13] Increase code coverage on state module saltmod Oct 10, 2023
@s0undt3ch s0undt3ch temporarily deployed to ci October 10, 2023 12:20 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 10, 2023 12:20 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 10, 2023 12:23 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 10, 2023 12:23 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 10, 2023 12:23 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 10, 2023 12:23 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

Merging #65372 (0a8ddaa) into 3006.x (05541f6) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           3006.x   #65372      +/-   ##
==========================================
+ Coverage   62.30%   62.35%   +0.06%     
==========================================
  Files        3218     3222       +4     
  Lines      442586   443010     +424     
  Branches    84722    84801      +79     
==========================================
+ Hits       275693   276203     +510     
+ Misses     151341   151267      -74     
+ Partials    15552    15540      -12
Flag Coverage Δ
almalinux-8 58.89% <100.00%> (+0.06%) ⬆️
almalinux-9 58.88% <100.00%> (+0.07%) ⬆️
amazonlinux-2 58.87% <99.69%> (+0.07%) ⬆️
archlinux-lts 58.80% <99.69%> (+0.07%) ⬆️
centos-7 58.94% <100.00%> (+0.07%) ⬆️
centosstream-8 58.91% <100.00%> (+0.06%) ⬆️
centosstream-9 58.90% <99.69%> (+0.06%) ⬆️
debian-10 58.10% <99.69%> (+0.07%) ⬆️
debian-11 58.07% <99.69%> (+0.07%) ⬆️
debian-11-arm64 58.06% <99.69%> (+0.07%) ⬆️
debian-12 58.06% <100.00%> (+0.06%) ⬆️
debian-12-arm64 58.05% <99.69%> (+0.07%) ⬆️
fedora-37 58.88% <99.69%> (+0.06%) ⬆️
fedora-38 58.82% <99.69%> (+0.07%) ⬆️
opensuse-15 57.88% <100.00%> (+0.08%) ⬆️
photonos-3 58.54% <99.69%> (+0.07%) ⬆️
photonos-4 58.52% <99.69%> (+0.07%) ⬆️
photonos-4-arm64 58.33% <100.00%> (+0.07%) ⬆️
salt 46.47% <100.00%> (+0.04%) ⬆️
tests 89.88% <100.00%> (+0.03%) ⬆️
ubuntu-20.04 58.10% <100.00%> (+0.06%) ⬆️
ubuntu-20.04-arm64 58.09% <99.69%> (+0.07%) ⬆️
ubuntu-22.04 58.09% <100.00%> (+0.06%) ⬆️
ubuntu-22.04-arm64 58.08% <100.00%> (+0.07%) ⬆️
windows-2016 46.72% <99.69%> (+0.14%) ⬆️
windows-2019 53.23% <99.69%> (-<0.01%) ⬇️
windows-2022 53.23% <99.69%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
salt/states/saltmod.py 83.18% <100.00%> (+30.49%) ⬆️
tests/pytests/unit/states/saltmod/test_function.py 100.00% <100.00%> (ø)
...tests/unit/states/saltmod/test_parallel_runners.py 100.00% <100.00%> (ø)
tests/pytests/unit/states/saltmod/test_runner.py 100.00% <100.00%> (ø)
tests/pytests/unit/states/saltmod/test_state.py 100.00% <100.00%> (ø)
...pytests/unit/states/saltmod/test_wait_for_event.py 100.00% <100.00%> (ø)
tests/pytests/unit/states/saltmod/test_wheel.py 100.00% <100.00%> (ø)

... and 31 files with indirect coverage changes

@s0undt3ch s0undt3ch temporarily deployed to ci October 10, 2023 14:20 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 10, 2023 14:20 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 10, 2023 14:20 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 10, 2023 14:20 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 10, 2023 14:20 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 10, 2023 14:20 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch force-pushed the hotfix/cc-batch-13-saltmod branch from 72c0a96 to dd105d8 Compare October 10, 2023 15:51
@s0undt3ch s0undt3ch temporarily deployed to ci October 10, 2023 16:08 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 10, 2023 16:08 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 10, 2023 16:09 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 10, 2023 16:09 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 10, 2023 16:09 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 10, 2023 16:09 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch added the test:full Run the full test suite label Oct 10, 2023
@s0undt3ch s0undt3ch force-pushed the hotfix/cc-batch-13-saltmod branch from dd105d8 to 8b19930 Compare October 10, 2023 18:11
@s0undt3ch s0undt3ch temporarily deployed to ci October 10, 2023 18:32 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 10, 2023 18:32 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 10, 2023 18:33 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 11, 2023 13:37 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 11, 2023 13:37 — with GitHub Actions Inactive
@s0undt3ch
Also fix broken shebangs
769a4a2 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Migrate existing tests to pytest
fd18432 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Bring migrated tests up to standards
cd3d543 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
These are not slow tests
fdc0051 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Increase code coverage on state module saltmod, function state
dec7606 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Split tests
0b95444 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Fix bug from 2017, by removing unwanted comma.
53c8372 
saltstack@fda41ed#diff-f6c5d53219e55de2e0d3321b81d1041965330dfd79f2f9eecb269df8ba829611R719

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Increase code coverage on state module saltmod, function function
3ede66a 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Increase code coverage on state module saltmod, function runner
53e9d1c 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Increase code coverage on state module saltmod, function `test_wait…
a92d85d 
…_for_event`

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Increase code coverage on state module saltmod, function wheel
fb7adf3 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Increase code coverage on state module saltmod, function `parallel_…
0a8ddaa 
…runners`

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch s0undt3ch force-pushed the hotfix/cc-batch-13-saltmod branch from 8b19930 to 0a8ddaa Compare October 15, 2023 11:52
@s0undt3ch s0undt3ch temporarily deployed to ci October 15, 2023 12:06 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 15, 2023 12:06 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 15, 2023 12:06 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 15, 2023 12:06 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 15, 2023 12:06 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 15, 2023 12:06 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 15, 2023 15:06 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 15, 2023 15:06 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 15, 2023 15:06 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 15, 2023 15:06 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 15, 2023 15:06 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci October 15, 2023 15:06 — with GitHub Actions Inactive
@Ch3LL Ch3LL merged commit 40be4e7 into saltstack:3006.x Oct 16, 2023
@s0undt3ch s0undt3ch deleted the hotfix/cc-batch-13-saltmod branch October 16, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ch3LL Ch3LL Ch3LL approved these changes

@twangboy twangboy Awaiting requested review from twangboy twangboy was automatically assigned from saltstack/team-core

Assignees
No one assigned
Labels
test:coverage test:full Run the full test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s0undt3ch @Ch3LL