Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] relative pillar includes only work in the current directory #57735

Open
OrangeDog opened this issue Jun 19, 2020 · 4 comments
Open

[BUG] relative pillar includes only work in the current directory #57735

OrangeDog opened this issue Jun 19, 2020 · 4 comments
Labels
Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone

Comments

@OrangeDog
Copy link
Contributor

Description
Pillars now support relative includes, but only a single level. They should behave the same as state includes.

Steps to Reproduce the behavior

include:
  - .one
  - ..two
  - ...three

Expected behavior
Includes should behave consistently across pillars and states.

Versions Report

salt --versions-report
Salt Version:
           Salt: 3001

Dependency Versions:
           cffi: Not Installed
       cherrypy: Not Installed
       dateutil: 2.6.1
      docker-py: Not Installed
          gitdb: Not Installed
      gitpython: Not Installed
         Jinja2: 2.10
        libgit2: 0.26.0
       M2Crypto: 0.32.0
           Mako: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.5.6
   mysql-python: Not Installed
      pycparser: Not Installed
       pycrypto: 2.6.1
   pycryptodome: 3.4.7
         pygit2: 0.26.2
         Python: 3.6.9 (default, Apr 18 2020, 01:56:04)
   python-gnupg: 0.4.1
         PyYAML: 3.12
          PyZMQ: 17.1.2
          smmap: Not Installed
        timelib: Not Installed
        Tornado: 4.5.3
            ZMQ: 4.2.5

System Versions:
           dist: ubuntu 18.04 Bionic Beaver
         locale: ISO-8859-1
        machine: x86_64
        release: 4.15.0-106-generic
         system: Linux
        version: Ubuntu 18.04 Bionic Beaver
@OrangeDog OrangeDog added the Bug broken, incorrect, or confusing behavior label Jun 19, 2020
@sagetherage sagetherage added the v3001 vulnerable --> v3001.7 or v3001.8 label Jun 19, 2020
@max-arnold
Copy link
Contributor

@waynew This issue describes the same problem I spotted earlier: #52156 (comment)

@sagetherage sagetherage removed the v3001 vulnerable --> v3001.7 or v3001.8 label Jun 22, 2020
@krionbsd krionbsd added this to the Follow up milestone Jun 22, 2020
@krionbsd
Copy link
Contributor

@OrangeDog thanks for the report, could you please write the patch if it's possible?

@OrangeDog
Copy link
Contributor Author

No, I have no idea what is the required, nor the time to do it.

@sagetherage sagetherage modified the milestones: Follow up, Magnesium Aug 5, 2020
@sagetherage sagetherage added Magnesium Mg release after Na prior to Al severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around labels Aug 5, 2020
@sagetherage sagetherage removed the Magnesium Mg release after Na prior to Al label Sep 29, 2020
@sagetherage sagetherage modified the milestones: Magnesium, Approved Sep 29, 2020
@OrangeDog
Copy link
Contributor Author

Assigning to @waynew, who implemented the original.

@dwoz dwoz unassigned waynew Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Development

No branches or pull requests

6 participants