salt_proxy.configure_proxy Creates Invalid Proxy Config File

[Silvenga]

Description of Issue

Two issues:

• When salt_proxy.configure_proxy was ran, /etc/salt/proxy existed and contained default data. It appear like it was left over from an older version of SaltStack. The master property was empty, so the proxy minion failed to connect to the master.
• When the /etc/salt/proxy file was removed manually, salt_proxy.configure_proxy created an invalid yaml file which caused salt-proxy to fail to startup:

Command '[u'salt-proxy', u'--proxyid={{ minion }}', u'-l', u'info', u'-d']' failed with return code: 1
2019-06-02 21:56:26,055 [salt.loaded.int.module.cmdmod:778 ][ERROR   ][80325] stderr: [ERROR   ] Error parsing configuration file: /etc/salt/proxy - conf should be a document, not <type 'unicode'>.

The file contained:

master = {{ salt master }}

Setup

Using the following state, with either an empty proxy configuration file or the default (just comments).

proxy.sls

Ensure proxy for minion {{ minion }} exists:
  salt_proxy.configure_proxy:
    - proxyname: {{ minion }}
    - start: true

Steps to Reproduce Issue

salt-call state.apply proxy

Versions Report

salt-call --versions-report                                                                                                                              [10:00PM]

Salt Version:
           Salt: 2018.3.3

Dependency Versions:
           cffi: 1.12.3
       cherrypy: Not Installed
       dateutil: 2.6.1
      docker-py: 4.0.1
          gitdb: Not Installed
      gitpython: Not Installed
          ioflo: Not Installed
         Jinja2: 2.10
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: Not Installed
           Mako: 1.0.7
   msgpack-pure: Not Installed
 msgpack-python: 0.5.6
   mysql-python: Not Installed
      pycparser: 2.19
       pycrypto: 2.6.1
   pycryptodome: Not Installed
         pygit2: Not Installed
         Python: 2.7.15rc1 (default, Nov 12 2018, 14:31:15)
   python-gnupg: 0.4.1
         PyYAML: 3.12
          PyZMQ: 16.0.2
           RAET: Not Installed
          smmap: Not Installed
        timelib: Not Installed
        Tornado: 4.5.3
            ZMQ: 4.2.5

System Versions:
           dist: Ubuntu 18.04 bionic
         locale: ISO-8859-1
        machine: x86_64
        release: 4.15.0-45-generic
         system: Linux
        version: Ubuntu 18.04 bionic

[garethgreenaway]

Looks like this was potentially fixed in PR #52171 I was unable to reproduce it using the latest release. The proxy file is written in the correct format and a proxy minion starts up. Salt version 2018.3.3 is also several years old and subject to many CVE issues. Closing this out one but if the problem persists with later versions please open a new issue. Thanks!