-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to run winrepo.update_git_repos #35993
Comments
@jbouse I'm having a hard time replicating this .Did you just see htis after upgrading to 2016.3.3. Di you just recently upgrade pygit2? |
I am having a similar problem. I did not use the feature before, I only tried it after upgrading ubuntu to 16.04 and salt to 2016.3.3.
|
@Ch3LL It worked with 2016.3.2 using GitPython on Debian 8 (Jessie) and Ubuntu 14.04 LTS. I just upgraded to Debian testing (Stretch) and Ubuntu 16.04 LTS in order to enable pygit2 for GitFS support since you can't use the privkey/pubkey options without pygit2. When I tried to run the winrepo.update_git_repos this afternoon it failed as I documented so I went ahead and upgraded to 2016.3.3 to see if that would fix it but there was no change in outcome. |
@Ch3LL My Salt Master configuration is managed using a fork of the salt-formula and being fed my pillar data. I don't change any of the winrepo related configuration settings and even though I specify the gitfs_provider to pygit2 I believe if I'm not mistaken that's the default provided it's available. |
@jbouse and @lubyou I think this might be related to libgit2. I found this issue: libgit2/libgit2#3786 How did you install libgit2? If you try the rebuild suggestions in that post does it work? Also @jbouse can you try installing
|
I also found this issue libgit2/pygit2#573 which might be useful for your situation to make sure libgit2 is functioning properly. |
@Ch3LL it seems that libgit2 is indeed built without openssl on Ubuntu 16.04. Thank you for your help! |
@lubyou awesome thanks for the feedback! Glad you got it working. |
I'm away for the holiday weekend and won't be back at a terminal I could do any testing from until Thursday; however, if the solution is in fact to recompile libpygit2 then it seems like upon my return my options are to either hope the upstream build bug is fixed in both Debian and Ubuntu and be able to upgrade the python-pygit2 package or I'll be rebuilding my salt master servers back on Ubuntu 14.04 and Debian 8 and then reverting back to using GitPython until pygit2 is more stable and readily available to use. Having to custom compile distribution packages to get it to work is an unacceptable solution for me. |
Found a better work around solution than recompiling the package... I just set winrepo_provider: gitpython in my salt master config since GitPython works fine with HTTPS URLs and in the case of winrepo_remotes_ng and winrepo_remotes I don't need to use authentiction which was the reason for moving to pygit2 for my pillar and state repositories. |
@jbouse glad you found a workaround. Are you okay to close this issue as it seems this is an upstream issue? |
@Ch3LL yeah we can close this... As well as it being an upstream build issue I've gotten a PR fix into the salt-formula that helps work around it. |
I have a patch to fix the issue in Debian and Ubuntu which would allow you to avoid these rebuilds. Please review! |
Description of Issue/Question
Running salt-run winrepo.update_git_repos is not working to populate the winrepo.
Setup
All default values using the pygit2 gitfs_provider
Steps to Reproduce Issue
Simply run salt-run winrepo.update_git_repos
Actual DNS resolution doesn't appear to be an issue:
Performing a normal git clone WINREPO_URL works fine from the host
Output from running with -l trace option
Versions Report
Also same behavior:
The text was updated successfully, but these errors were encountered: