CI check should be added to ensure tests do not leave files behind

[mchugh19]

Description of Issue/Question

When running some tests, files are generated and are not cleaned up. This activity should be prohibited and checked through CI.

Steps to Reproduce Issue

# ls /tmp
systemd-private-593e53c8f2b34e57a0cd3cc966f56283-chronyd.service-tLhU37  systemd-private-c3ac1dad1df942e78e25523b6fc6d51b-chronyd.service-e5vREA
systemd-private-74af3fa3d9634bc180764ceaa82003b8-chronyd.service-dbjMQs

# python tests/runtests.py -n unit.modules.test_file
... test output ...
============================================================================================================================================
OK (total=80, skipped=0, passed=80, failures=0, errors=0)
=================================================================  Overall Tests Report  ===================================================

# ls /tmp
salt-runtests.log                                                        tmpc80PlZ.bak  tmpKspK44.bak  tmpPC5u_F      tmpwN0KAg.bak
systemd-private-593e53c8f2b34e57a0cd3cc966f56283-chronyd.service-tLhU37  tmp54nv9V.bak  tmpDG7R2d.bak  tmpkYONar.bak  tmpPC5u_F.bak  tmpx99Nhp.bak
systemd-private-74af3fa3d9634bc180764ceaa82003b8-chronyd.service-dbjMQs  tmp_9u6Pp.bak  tmpdybBfI.bak  tmpMn_NeS.bak  tmpq_8wln.bak  tmpYblrBq.bak
systemd-private-c3ac1dad1df942e78e25523b6fc6d51b-chronyd.service-e5vREA  tmpAZHCBr.bak  tmpJI79d2.bak  tmpOzaXCQ.bak  tmptCdgKX.bak  tmpYxjgVi.bak

Versions Report

# salt --versions-report
Salt Version:
           Salt: 2018.3.2

Dependency Versions:
           cffi: Not Installed
       cherrypy: Not Installed
       dateutil: Not Installed
      docker-py: Not Installed
          gitdb: Not Installed
      gitpython: Not Installed
          ioflo: Not Installed
         Jinja2: 2.10
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: Not Installed
           Mako: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.5.6
   mysql-python: Not Installed
      pycparser: Not Installed
       pycrypto: 2.6.1
   pycryptodome: Not Installed
         pygit2: Not Installed
         Python: 2.7.5 (default, Jul 13 2018, 13:06:57)
   python-gnupg: Not Installed
         PyYAML: 3.13
          PyZMQ: 17.1.2
           RAET: Not Installed
          smmap: Not Installed
        timelib: Not Installed
        Tornado: 5.1.1
            ZMQ: 4.2.5

System Versions:
           dist: centos 7.5.1804 Core
         locale: UTF-8
        machine: x86_64
        release: 3.10.0-862.14.4.el7.x86_64
         system: Linux
        version: CentOS Linux 7.5.1804 Core

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[mchugh19]

I think it's still a good idea

[stale[bot]]

Thank you for updating this issue. It is no longer marked as stale.