[FEATURE REQUEST] improvement of windows kb uninstallation

[sfonteneau]

I am working on a solution that matches yours (wapt.fr).
But nothing stops us from joining forces!

For :

salt/salt/utils/win_update.py

Line 986 in daef761

if "kb" + kb in item.lower():

I'm sharing with you an improvement that I found to uninstall Windows KB:

import xml.etree.ElementTree as ET
import glob
import run
import disable_file_system_redirection

def get_kb_dism_name():

    dict_dism_kb={}

    with disable_file_system_redirection():
        for f in glob.glob(r'C:\Windows\servicing\Packages\*.mum'):
            identifier = None
            dism_name = None
            tree =  ET.parse(f)
            root =  tree.getroot()
            for child in root:
                if child.tag == '{urn:schemas-microsoft-com:asm.v3}assemblyIdentity':
                    dism_name = child.attrib['name'] + '~' + child.attrib['publicKeyToken'] + "~" + child.attrib['processorArchitecture'] + '~~' + child.attrib['version']
                if child.tag == '{urn:schemas-microsoft-com:asm.v3}package':
                    identifier = child.attrib['identifier']

            if dism_name and identifier :
                dict_dism_kb[dism_name] = identifier

        dict_final_dism_kb = {}
        data = run('dism /Online /Get-Packages')
        for entry in data.splitlines():
            if entry.split(' : ',1)[-1] in dict_dism_kb:
                name_entry = entry.split(' : ',1)[-1]
                dict_final_dism_kb[dict_dism_kb[name_entry].lower()] = name_entry

    return dict_final_dism_kb

def test():

    data_dism=get_kb_dism_name()

    dism_name = data_dism['kb5005699']

    print('dism /Online /Remove-Package /PackageName:%s /Quiet /NoRestart' % dism_name)
    
    
test()

With this we can find the dism name of a kb even if the kb name is not in dism name.

See you soon !

[welcome[bot]]

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

• Community Wiki
• Salt’s Contributor Guide
• Join our Community Slack
• IRC on LiberaChat
• Salt Project YouTube channel
• Salt Project Twitch channel

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!