Update PagerDuty module to use the new PagerDuty API

[kajigga]

Description of Issue/Question

The PagerDuty module salt/utils/pagerduty.py currently uses the v1 version of the PagerDuty API. This version of their API will be decommissioned on Oct 19 and will no longer function. The SaltStack integration guide at https://www.pagerduty.com/docs/guides/saltstack-integration-guide/ describes the change and https://v2.developer.pagerduty.com/v2/docs/v1-rest-api-decommissioning-faq gives more details.

The new v2 of their API is available and a migration path is described at https://v2.developer.pagerduty.com/docs/migrating-to-api-v2

Based on how quickly a fix is developed and an PR accepted, we may want this module to work with both v1 and v2. Systems currently using it will have a v1 key in use. While they must upgrade to a v2 key by October 19 2018, any releases prior to that should probably still allow v1 keys to function.

Setup

Standard PagerDuty setup.

Steps to Reproduce Issue

Both the old and new API's are available right now. The v2 api is preferred. In fact, new PagerDuty customers must request make special requests to obtain v1 API access keys.

Versions Report

This affects all salt versions

[travispaul]

Would it be possible to note the requirement for a V1 API key on the PagerDuty state module, execution module, and runner module documentation?

The error messages from salt when using a V2 API key are not obvious and you have to contact PagerDuty support to get a V1 API Key.

[jbaldo]

PagerDuty V1 REST API keys will work with the v2 REST API after the upgrade is complete. You can request to use v2 with a v1 API key in the Accept header of the request.

More: https://v2.developer.pagerduty.com/docs/versioning

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[stale[bot]]

Thank you for updating this issue. It is no longer marked as stale.

[racooper]

This definitely needs to be updated. PagerDuty API v2 has been active for nearly 5 years now and v1 has been officially decommissioned.