RFE: PyGit2 backend should also support SSH Agent Authentication

[The-Loeki]

Description of Issue/Question

In Salt-SSH rosters you can already use agent-forwarding to use a key from the SSH Agent.
Using GitPython as backend for the gitfs SSH Agent auth (accidentally) also works

PyGit2 has support for this as well, but the code needs some minor adjustments to make it work.

[terminalmage]

Do you have any examples of this? There's no mention of agent forwarding in the documentation for the Credentials objects.

[The-Loeki]

libgit2/pygit2#424

[terminalmage]

Oh, cool! Odd that this has never made it into their documentation. I'll play around with this and try to get it into Salt. Thanks for the link!

I can't promise this will make the next feature release because Python 3 support is a higher priority right now, but I'll try to make it happen.

[The-Loeki]

That's OK :) there's obvious and good workarounds for it so no high prio.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[The-Loeki]

not stale

[stale[bot]]

Thank you for updating this issue. It is no longer marked as stale.