Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't generate DSA ssh key if system FIPS is enabled #80

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

s0undt3ch
Copy link
Contributor

No description provided.

@s0undt3ch s0undt3ch force-pushed the hotfix/fips branch 2 times, most recently from ebfbeb6 to e43bfe6 Compare September 13, 2021 18:18
@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #80 (5b04f2c) into master (d6859b6) will decrease coverage by 2.81%.
The diff coverage is 97.44%.

❗ Current head 5b04f2c differs from pull request most recent head 44c9016. Consider uploading reports for the commit 44c9016 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   88.43%   85.62%   -2.80%     
==========================================
  Files         135      135              
  Lines        7332     7370      +38     
  Branches      846      854       +8     
==========================================
- Hits         6483     6310     -173     
- Misses        623      782     +159     
- Partials      226      278      +52     
Flag Coverage Δ
Linux 85.52% <97.44%> (?)
Py37 83.52% <97.30%> (?)
Py39 85.52% <97.44%> (?)
PyTest62 85.57% <97.44%> (?)
Salt3002_6 85.57% <97.44%> (?)
Salt3003 85.57% <97.44%> (?)
macOS 83.52% <97.30%> (?)
src 77.80% <96.00%> (?)
tests 95.67% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/saltfactories/daemons/sshd.py 81.40% <66.67%> (-0.49%) ⬇️
src/saltfactories/utils/platform.py 97.11% <100.00%> (+1.36%) ⬆️
tests/unit/utils/test_platform.py 100.00% <100.00%> (ø)
tests/unit/utils/markers/test_skip_if_not_root.py 60.00% <0.00%> (-40.00%) ⬇️
src/saltfactories/utils/processes.py 68.43% <0.00%> (-22.55%) ⬇️
tests/conftest.py 78.88% <0.00%> (-18.30%) ⬇️
src/saltfactories/daemons/minion.py 79.00% <0.00%> (-17.00%) ⬇️
src/saltfactories/daemons/proxy.py 74.79% <0.00%> (-16.80%) ⬇️
src/saltfactories/daemons/master.py 77.02% <0.00%> (-15.52%) ⬇️
tests/functional/markers/test_skip_if_not_root.py 84.62% <0.00%> (-15.38%) ⬇️
... and 10 more

@s0undt3ch s0undt3ch merged commit 2101416 into saltstack:master Sep 14, 2021
@s0undt3ch s0undt3ch deleted the hotfix/fips branch September 14, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants