Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_unused_localhost_port no longer cached returned port by default #51

Merged
merged 4 commits into from
Apr 14, 2021

Conversation

s0undt3ch
Copy link
Contributor

No description provided.

@s0undt3ch s0undt3ch force-pushed the master branch 2 times, most recently from e755f93 to 650cf58 Compare April 14, 2021 17:12
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #51 (b50e97d) into master (699c1b3) will decrease coverage by 0.04%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   87.02%   86.98%   -0.05%     
==========================================
  Files         131      131              
  Lines        7199     7192       -7     
  Branches      846      844       -2     
==========================================
- Hits         6265     6256       -9     
- Misses        670      673       +3     
+ Partials      264      263       -1     
Flag Coverage Δ
86.38% <93.33%> (-0.05%) ⬇️
Linux 85.76% <93.33%> (+0.01%) ⬆️
factories 86.27% <93.33%> (-0.05%) ⬇️
macOS 82.13% <93.33%> (-0.02%) ⬇️
py36 83.69% <93.33%> (+0.01%) ⬆️
py37 83.75% <93.33%> (-0.02%) ⬇️
py38 85.73% <93.33%> (+0.01%) ⬆️
py39 84.22% <93.33%> (+0.01%) ⬆️
salt_3002_6 84.28% <93.33%> (-0.02%) ⬇️
system 44.68% <20.00%> (-0.10%) ⬇️
tests 34.35% <25.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/saltfactories/utils/ports.py 88.23% <90.90%> (-1.51%) ⬇️
tests/unit/utils/test_ports.py 100.00% <100.00%> (ø)
src/saltfactories/utils/processes.py 69.38% <0.00%> (-1.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 699c1b3...b50e97d. Read the comment docs.

@s0undt3ch s0undt3ch merged commit 1dab1ad into saltstack:master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant